Improve error handling

Use fancy_handle to report errors.  There is no separate
LocalWorkspaceModel any longer, only ServerWorkspaceModel with a base
class.

* Follow PEP 8 naming rules

* Improve error handling bookmarks

* Handle workspaces well during disconnect/reconnect

* Support file browsing while disconnect

* Update user menu correctly on disconnect

* Improve disconnect while logging in

* Remove unnecessary handle calls

* Handle share link disconnect better

* Handle versions while disconnected

* Handle preferences while disconnected

* Support deleting directories while disconnecting

* Support deleting files while disconnecting

* Make sharelink and active version disconnect aware

* Handle models better

* Improve handling disconnected wrt models

Workspaces and workspace models are refreshed each time we get to
disconnected state.

Author: pieterhijma

APIClient.py

@@ -110,7 +110,10 @@ def setStatus(self, newStatus):
             self.parent.set_ui_connectionStatus()
 
     def getStatus(self):
-        """gets the current connection status; this is an active check to see if really online"""
+        """
+        Gets the current connection status;
+        This is an active check to see if really online.
+        """
         self._confirm_online()
         return self.status
 
@@ -193,9 +196,12 @@ def _set_content_type(self):
         return headers
 
     def _confirm_online(self):
-        """calls lens api root to simply check if online. if not online, updates status"""
+        """
+        Calls lens api root to simply check if online.
+        If not online, updates status.
+        """
         try:
-            response = requests.get(f"{self.base_url}/")
+            requests.get(f"{self.base_url}/")
             if self.is_logged_in():
                 self.setStatus(ConnStatus.CONNECTED)
             else:
@@ -207,13 +213,13 @@ def _confirm_online(self):
     def _confirm_online_after_exception(self):
         self._confirm_online()
         if self.status == ConnStatus.DISCONNECTED:
-            raise APIClientOfflineException("Safely offline")
+            raise APIClientOfflineException("Disconnected from service: logged out")
 
     def _properly_throw_if_offline(self):
         if self.status == ConnStatus.DISCONNECTED:
             self._confirm_online()  # try to connect again
             if self.status == ConnStatus.DISCONNECTED:
-                raise APIClientOfflineException("Safely offline")
+                raise APIClientOfflineException("Disconnected from service: logged out")
 
     def _delete(self, endpoint, headers={}, params=None):
         headers = self._set_default_headers(headers)
@@ -919,7 +925,7 @@ def filterFilter(data):
             return data
 
 
-class API_Call_Result(Enum):
+class APICallResult(Enum):
     OK = 1  # all is good
     DISCONNECTED = 2  # all is good but not online
     NOT_LOGGED_IN = 3  # not logged in, so _this_ query is not possible
@@ -941,27 +947,25 @@ def fancy_handle(func):
     make sure you are doing "result = fancy_handle(joe)" not
     "result = fancy_handle(joe())"
 
-    Returns an API_Call_Result enum value. It is expected that the caller
+    Returns an APICallResult enum value. It is expected that the caller
     handles all the possible return states.
     """
     try:
         func()
-        return API_Call_Result.OK
-    except APIClientOfflineException as e:
-        return API_Call_Result.DISCONNECTED
-    except APIClientLoggedOutException as e:
-        return API_Call_Result.NOT_LOGGED_IN
+        return APICallResult.OK
+    except APIClientOfflineException:
+        return APICallResult.DISCONNECTED
+    except APIClientLoggedOutException:
+        return APICallResult.NOT_LOGGED_IN
     except APIClientRequestException as e:
         logger.error(e)
-        return API_Call_Result.GENERAL_ERROR
+        return APICallResult.GENERAL_ERROR
     except APIClientAuthenticationException as e:
         logger.error(e)
-        return API_Call_Result.PERMISSION_ISSUE
+        return APICallResult.PERMISSION_ISSUE
     except APIClientException as e:
         logger.error(e)
-        return API_Call_Result.GENERAL_ERROR
+        return APICallResult.GENERAL_ERROR
     except Exception as e:
         logger.error(e)
-        return API_Call_Result.GENERAL_ERROR
-    self.set_ui_connectionStatus()
-    return True
+        return APICallResult.GENERAL_ERROR

DataModels.py

@@ -14,9 +14,10 @@
 
 import FreeCAD
 
+from APIClient import fancy_handle, APICallResult
+
 
 CACHE_PATH = FreeCAD.getUserCachePath() + "Ondsel-Lens/"
-p = FreeCAD.ParamGet("User parameter:BaseApp/Ondsel")
 
 
 class WorkspaceListModel(QAbstractListModel):
@@ -46,12 +47,12 @@ def set_api(self, api):
         self.api = api
 
     def refreshModel(self):
-        # raises an APIClientException
-        self.beginResetModel()
-        if self.api is not None and self.api.is_logged_in():
-            # the user may be disconnected
+        def try_get_workspaces_connected():
             self.workspaces = self.api.getWorkspaces()
 
+        self.beginResetModel()
+        api_result = fancy_handle(try_get_workspaces_connected)
+        if api_result == APICallResult.OK:
             self.save()
         else:
             self.load()

Utils.py

@@ -37,6 +37,8 @@
 NAME_COMMAND_START = "Start_Start"
 LENS_TOOLBARITEM_TEXT = "Ondsel Lens Addon"
 
+SIZE_PIXMAP = 128
+
 
 class FreeCADHandler(logging.Handler):
     def __init__(self):
@@ -126,7 +128,9 @@ def extract_thumbnail(file_path):
                 pixmap = QPixmap()
                 pixmap.loadFromData(thumbnail_data)
 
-                return pixmap.scaled(128, 128, Qt.AspectRatioMode.KeepAspectRatio)
+                return pixmap.scaled(
+                    SIZE_PIXMAP, SIZE_PIXMAP, Qt.AspectRatioMode.KeepAspectRatio
+                )
 
         except (zipfile.BadZipFile, KeyError):
             # Handle the case where the thumbnail file doesn't exist