User is told research enrollment succeeded when it failed

[barbeau]

Summary:

We had a performance issue with the Google script powering the participant enrollment that it was timing out, and therefore not successfully enrolling participants. However, the Toast shown to the user said they had successfully enrolled, but then they were prompted to enroll again when re-opening the app.

We should tell the user when enrollment failed so it's not confusing if they are prompted to enroll again later.

Also, to reduce the impact of future failures, we should only prompt for enrollment every X number of starts, instead of every start (after initial start).

Steps to reproduce:

1. Try to enroll in the study when prompted and have the Google Script time out server-side

Expected behavior:

Tell the user enrollment failed and they will need to try again later

Observed behavior:

User is told that enrollment was successful

Device and Android version:

Confirmed via Samsung Galaxy S8+ w/ Android 9

[barbeau]

Looking at this further, even when changing the URL for user registration to an invalid URL and within saveEmailAddress() an IOException is thrown, onSuccess() is still triggered within TravelBehaviorManager on line 293. So looks like an issue with the Futures callback.

[barbeau]

Some initial testing here - https://github.com/OneBusAway/onebusaway-android/tree/fix-register-users. So far unsuccessful - same issue remains.

[amrhossamdev]

Closing due to disabling