Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Agent replies are missing words #431

Open
dekdynamics opened this issue May 28, 2024 · 3 comments
Open

Issue: Agent replies are missing words #431

dekdynamics opened this issue May 28, 2024 · 3 comments

Comments

@dekdynamics
Copy link

After the latest update, the agent replies quickly, however this question never gets a proper answer:

image

Note that the 2nd and 5th messages are also from the agent, even though it says "You."

I considered for a moment that Poon, as in Joseph Poon, might be a banned word. There is definitely something interesting about the word:

image

Other answers are much better and faster than before.

Copy link

greptile-apps bot commented May 28, 2024

To address the issue of missing words in agent replies, follow these steps:

  1. Check Message Handling in Chat.php:

    • Review the sendMessage method in /app/Livewire/Chat.php to ensure messages are being appended correctly.
    • Ensure the runAgentWithoutRag and ragRun methods are correctly processing and appending agent responses.
  2. Review Inference Methods:

    • In /app/AI/OpenAIGateway.php, check the inference method for any issues with message streaming and token handling.
    • In /app/AI/SimpleInferencer.php, review the inference method to ensure messages are not being truncated due to token limits. Pay special attention to the getTruncatedMessages method to verify that messages are being correctly truncated and appended.
  3. Token Limits and Truncation:

    • Ensure that the remainingTokens and promptTokens are being calculated correctly in SimpleInferencer.php.
    • Verify that the addMessage method in SimpleInferencer.php is correctly handling message tokens and not causing unintended truncation.
  4. Debugging:

    • Add logging in the inference methods to capture the full input and output messages for debugging purposes.
    • Check if specific words or phrases are being filtered or causing issues during the inference process.

By following these steps, you should be able to identify and resolve the issue with missing words in agent replies.

References

/app/Livewire/Chat.php
/app/AI/OpenAIGateway.php
/app/AI/SimpleInferencer.php
/app/AI
/app/Livewire/Agents

Ask Greptile

@svemir
Copy link
Contributor

svemir commented May 29, 2024

This is not an issue on OpenAgents end. OA currently uses the comman-r-plus model to pose the final question (after combining the user prompt, the agent instructions, and the rag context.) Here is what I get when I ask this question from command-r-plus directly on Cohere website:

Screenshot 2024-05-28 at 9 08 09 PM

@AtlantisPleb
Copy link

Hilarious. We'll accelerate allowing agent builders to specify different base models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants