Bond irregular dates #2694
Open
Bond irregular dates #2694
+208
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.10.2 to 5.11.2. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.10.2...r5.11.2) --- updated-dependencies: - dependency-name: org.junit:junit-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* overnight cap product * tests * javadoc * line * clean * white spaces * failing test for accrual
* PROD-42681: Adding Inauguration Day to MXMC * PROD-42681: Adding Inauguration Day to MXMC
* Overnight CapFloor CSV plugin * copyright * variable names --------- Co-authored-by: Alexis Skitini <[email protected]>
* overnight cap product * tests * javadoc * line * clean * white spaces * pricers * failing test for accrual * pricers * test * spaces * addressed review comments * error message
* Adding Inauguration Day to MXMC * Adding Inauguration Day to MXMC * Adding Inauguration Day to MXMC
Co-authored-by: Michael Rollins <[email protected]>
* Adding Overnight-Overnight swap conventions * Cleanup + Add Tests * PR cleanup * Finish PR feedback * Fix tests * Make constant public to fix ini loading --------- Co-authored-by: Brian Weller <[email protected]>
* Holiday for President Jimmy Carter * Only appears to apply to NYSE * https://www.sifma.org/resources/unscheduled-close-market-matrix/ * Fixes #2691
Bumps [com.google.guava:guava](https://github.com/google/guava) from 32.1.3-jre to 33.4.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.11.2 to 5.11.4. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit-framework@r5.11.2...r5.11.4) --- updated-dependencies: - dependency-name: org.junit:junit-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.25.3 to 3.27.0. - [Release notes](https://github.com/assertj/assertj/releases) - [Commits](assertj/assertj@assertj-build-3.25.3...assertj-build-3.27.0) --- updated-dependencies: - dependency-name: org.assertj:assertj-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
* Provide default value for new property * Adjust code to pull out events per year
|
The year 2025 starts very nicely. Thank you for reviewing my modifications. |
yukiiwashita
approved these changes
Jul 17, 2025
|
There are other lines where the logic should be changed:
In fact everty time there is a "++pow" There is also this odd/ugly name function I can fix my PR with some guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code from #2655. Applies a fix to
dirtyPriceFromYieldStandardforFixedCouponBond.The main change is the use of
Math.pow(factorOnPeriod, yearFraction * eventsPerYear)instead offactorOnPeriodwhen the period is not regular.