ohmx-adiff for osmcha #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Github action to deploy ohmx-adiff Add s3 bucket env var for ohmx-adiff Update env path for ohmx-adiff Create dir for db - ohmx-adiff Update path for diff files Update path dir Add make to run app in ohmx-adiff Store adiff files in ohm-augmented-diffs/changesets dir Add config for production Update container name for ohmx-adiff Update planet file version Update version for ohmx adiff
Member
Author
|
I just copied the new Docker image from osmcha-frontend into the production environment manually, since this is not something critical to edit, and the adiff files are working fine, called from the aws s3 bucket. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From OpenHistoricalMap/issues#1042
I’ve been working on creating an OSMX database instance for OHM to generate the adiff files (Currently it is running in hetzner). These adiff files will be generated at https://planet.openhistoricalmap.org/?prefix=ohm-augmented-diffs/, so we will no longer need to set up a new bucket in Cloudflare(as in OpenStreetMap does) — we will generate the adiff files and upload them directly to S3, from which a URL will be generated and set in the osmcha-frontend. https://github.com/OpenHistoricalMap/osmcha-frontend/blob/staging/src/config/constants.js#L22
Also, I created a PR to modify some parts of the
osmx-adiff-builderscript to make it work in the container: OSMCha/osmx-adiff-builder#5