Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize component defaults across Aviary #605

Open
jkirk5 opened this issue Nov 13, 2024 · 0 comments
Open

Standardize component defaults across Aviary #605

jkirk5 opened this issue Nov 13, 2024 · 0 comments
Labels
code cleanup Code cleanup, refactoring, or similar helpful reorganization

Comments

@jkirk5
Copy link
Contributor

jkirk5 commented Nov 13, 2024

Desired capability or behavior.

With many of our components, default values for inputs/outputs are provided that come from a variety of sources - maybe there were old GASP defaults, generally reasonable values, or values that match a particular aircraft model. This is not desired for a variety of reasons.

  • These defaults can differ from what is specified in the variable metadata, which confuses which value is the "true" default
  • It can make it difficult to realize that a value was never set/specified
  • It perpetuates bad coding practices, where data should be kept separate from code
    among other things. A standard default (such as 0 or 1) should be enforced for all component inputs/outputs. Options may want similar treatment but may require additional thought before implementing.

Is your feature request related to a problem? Please describe.

No response

Associated Bug Report

No response

@jkirk5 jkirk5 added the code cleanup Code cleanup, refactoring, or similar helpful reorganization label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Code cleanup, refactoring, or similar helpful reorganization
Projects
None yet
Development

No branches or pull requests

1 participant