Skip to content

Commit 6d861d4

Browse files
dragos-oancearazvancrainea
authored andcommitted
rtpengine: fail the call when rtpengine replies with an error
Since the failover change (3d0959a), an error reply that is not a failover error breaks out of the retry loop and is returned as a success. So rtpengine_delete(), the recording, block, forward and unsubscribe functions return true when rtpengine refused them, and error_pv is never set for such errors. Go to the error path instead, as before that change and as the async path does. (cherry picked from commit 9aa23bf)
1 parent fbca97a commit 6d861d4

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎modules/rtpengine/rtpengine.c‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2967,7 +2967,11 @@ static bencode_item_t *rtpe_function_call(bencode_buffer_t *bencbuf, struct sip_
29672967
else
29682968
continue; /* one more loop */
29692969
} else {
2970-
break; /* break the loop and exit with error */
2970+
/* not a failover error - fail the call */
2971+
RTPE_STOP_READ();
2972+
if (!error.len)
2973+
err = "proxy returned an error";
2974+
goto error;
29712975
}
29722976
}
29732977
} else {

0 commit comments

Comments
 (0)