Fix TranslatedEtiquetteValidator to use Decidim.enable_etiquette_validator setting (decidim#15092)

Author: takahashim

decidim-core/app/validators/translated_etiquette_validator.rb

@@ -6,6 +6,8 @@
 #   validates :my_i18n_field, translated_etiquette: true
 class TranslatedEtiquetteValidator < EtiquetteValidator
   def validate_each(record, attribute, _value)
+    return unless Decidim.enable_etiquette_validator
+
     translated_attr = "#{attribute}_#{default_locale_for(record)}".gsub("-", "__")
     translated_value = record.send(translated_attr)
     return if translated_value.blank?

decidim-core/spec/validators/translated_etiquette_validator_spec.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe TranslatedEtiquetteValidator do
+  subject { validatable.new(body:, current_organization:) }
+
+  let(:validatable) do
+    Class.new do
+      def self.model_name
+        ActiveModel::Name.new(self, nil, "Validatable")
+      end
+
+      def self.translatable_fields(*fields)
+        @translatable_fields = fields
+      end
+
+      include Decidim::AttributeObject::Model
+      include ActiveModel::Validations
+
+      attribute :body
+      attribute :current_organization
+
+      translatable_fields :body
+
+      validates :body, translated_etiquette: true
+
+      # Add accessor for translated fields
+      def body_en
+        body[:en]
+      end
+    end
+  end
+
+  let(:current_organization) { create(:organization, default_locale: :en) }
+
+  let(:body) { { en: "A SCREAMING BODY WITH TOO MANY CAPS" } }
+
+  context "when Decidim.enable_etiquette_validator is false" do
+    before do
+      allow(Decidim).to receive(:enable_etiquette_validator).and_return(false)
+    end
+
+    it "skips validation for all translatable fields" do
+      expect(subject).to be_valid
+    end
+  end
+
+  context "when Decidim.enable_etiquette_validator is true" do
+    before do
+      allow(Decidim).to receive(:enable_etiquette_validator).and_return(true)
+    end
+
+    context "with invalid content" do
+      it "performs validation on translatable fields" do
+        expect(subject).not_to be_valid
+        expect(subject.errors[:body_en]).not_to be_empty
+      end
+    end
+
+    context "with valid content" do
+      let(:body) { { en: "This is a reasonable body with proper capitalization" } }
+
+      it "allows valid content" do
+        expect(subject).to be_valid
+      end
+    end
+  end
+end