Commit 2915e48
committed
ci: add read-only workflow token permissions and fix template injection
All four workflows lacked a top-level permissions block, so they
inherited the repository default, which can be write-all on permissive
settings.
- build.yaml, coverity-scan.yml, doxygen.yml: add `permissions: read-all`
at the workflow level. The doxygen deploy job retains its existing
job-level `pages: write` and `id-token: write` overrides, which take
precedence for that job only.
- test-ssllib.yml: add `permissions: read-all` and replace seven direct
`${{inputs.*}}` template expansions inside `run:` blocks with env-var
references (LIB_CONFIGURE, LIB_MAKE, LIB_INSTALL, OVPN_LIBNAME,
OVPN_CONFIGURE_FLAGS, OVPN_LIBDESC, OVPN_CONFIGURE_ENV) to eliminate
the zizmor template-injection findings. The configure prefix that sets
crypto-library env vars is now passed through `env -S` instead of direct
interpolation, preserving behaviour while avoiding shell-injection risk.
Verified with zizmor --min-severity medium: 0 high-severity findings
after this patch (down from 9).
Signed-off-by: Alb3e3 <tomaska.filip@gmail.com>1 parent c9b5f9e commit 2915e48
4 files changed
Lines changed: 21 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
| 8 | + | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| |||
65 | 67 | | |
66 | 68 | | |
67 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
68 | 77 | | |
69 | 78 | | |
70 | 79 | | |
| |||
85 | 94 | | |
86 | 95 | | |
87 | 96 | | |
88 | | - | |
| 97 | + | |
89 | 98 | | |
90 | 99 | | |
91 | 100 | | |
92 | | - | |
| 101 | + | |
93 | 102 | | |
94 | 103 | | |
95 | 104 | | |
96 | | - | |
| 105 | + | |
97 | 106 | | |
98 | 107 | | |
99 | 108 | | |
| |||
103 | 112 | | |
104 | 113 | | |
105 | 114 | | |
106 | | - | |
107 | | - | |
| 115 | + | |
| 116 | + | |
108 | 117 | | |
109 | 118 | | |
110 | 119 | | |
111 | 120 | | |
112 | 121 | | |
113 | | - | |
| 122 | + | |
114 | 123 | | |
115 | 124 | | |
116 | 125 | | |
| |||
0 commit comments