Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CR-01]: Put necessary derives for contracterrors #30

Open
ozgunozerk opened this issue Feb 5, 2025 · 0 comments · May be fixed by #31
Open

[CR-01]: Put necessary derives for contracterrors #30

ozgunozerk opened this issue Feb 5, 2025 · 0 comments · May be fixed by #31
Assignees
@ozgunozerk
Labels
audit

Comments

@ozgunozerk
Copy link
Collaborator

What happened?

Quoting from the official stellar docs:

The enum has some constraints:

  • It must have the #[repr(u32)] attribute.
  • It must have the #[derive(Copy)] attribute.
  • Every variant must have an explicit integer value assigned.

So, to follow best practices, we should put these derives for every contracterror

Expected behavior

No response
@ozgunozerk ozgunozerk self-assigned this Feb 5, 2025
@ozgunozerk ozgunozerk linked a pull request Feb 5, 2025 that will close this issue
Open
@brozorec brozorec added the audit label Feb 7, 2025
@brozorec brozorec moved this from Todo to Done in Stellar Contracts Feb 7, 2025
@brozorec brozorec moved this from Done to In Progress in Stellar Contracts Feb 7, 2025
@brozorec brozorec changed the title 🐞 [Bug]: Put necessary derives for contracterrors [CR-01]: Put necessary derives for contracterrors Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ozgunozerk ozgunozerk

Labels
audit
Projects
Stellar Contracts
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CR-01] Put necessary derives for the contract errors OpenZeppelin/stellar-contracts
2 participants
@brozorec @ozgunozerk