Fix: handle null cases in callback functions (#37)

NielsJPeschel · web-flow · commit ab5acc423f74 · 2024-10-22T11:00:29.000-04:00
* Fix: handle null cases in callback functions

* updated version to next
diff --git a/hooks/useLoadData/callbacks/complete/complete.ts b/hooks/useLoadData/callbacks/complete/complete.ts
@@ -2,7 +2,7 @@ export function complete<T>(onSuccess?: (data: T) => void, onError?: (error: unk
   return (err?: unknown, res?: T) => {
     if (err) {
       onError?.(err);
-    } else if (res) {
+    } else if (res || res === null) {
       onSuccess?.(res);
     }
   };
diff --git a/hooks/useLoadData/callbacks/success/success.ts b/hooks/useLoadData/callbacks/success/success.ts
@@ -1,6 +1,6 @@
 export function success<T>(onSuccess?: (data: T) => void) {
   return (err?: unknown, res?: T) => {
-    if (res) {
+    if (res || res === null) {
       onSuccess?.(res);
     }
   };
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@optum/react-hooks",
-  "version": "1.0.3",
+  "version": "1.0.3-next.1",
   "description": "A reusable set of React hooks",
   "repository": "https://github.com/Optum/react-hooks",
   "license": "Apache 2.0",

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ export function complete<T>(onSuccess?: (data: T) => void, onError?: (error: unk`
`2`	`2`	`return (err?: unknown, res?: T) => {`
`3`	`3`	`if (err) {`
`4`	`4`	`onError?.(err);`
`5`		`- } else if (res) {`
	`5`	`+ } else if (res \|\| res === null) {`
`6`	`6`	`onSuccess?.(res);`
`7`	`7`	`}`
`8`	`8`	`};`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`export function success<T>(onSuccess?: (data: T) => void) {`
`2`	`2`	`return (err?: unknown, res?: T) => {`
`3`		`- if (res) {`
	`3`	`+ if (res \|\| res === null) {`
`4`	`4`	`onSuccess?.(res);`
`5`	`5`	`}`
`6`	`6`	`};`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@optum/react-hooks",`
`3`		`- "version": "1.0.3",`
	`3`	`+ "version": "1.0.3-next.1",`
`4`	`4`	`"description": "A reusable set of React hooks",`
`5`	`5`	`"repository": "https://github.com/Optum/react-hooks",`
`6`	`6`	`"license": "Apache 2.0",`