Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread Dump Analysis #141

Open
luiscolorado opened this issue May 24, 2019 · 1 comment
Open

Thread Dump Analysis #141

luiscolorado opened this issue May 24, 2019 · 1 comment

Comments

@luiscolorado
Copy link
Contributor

luiscolorado commented May 24, 2019

FEATURE / ENHANCEMENT

Add a thread-dump-analysis feature to the thread dumps functionality.

This enhancement would add a button "Analyze" to read the current tab/thread and summarize/analyze the thread dump using https://spotify.github.io/threaddump-analyzer/

For this it would be necessary to link to https://spotify.github.io/threaddump-analyzer/ to bring the javascript code and translate the text.

Spotify's TDA runs on the client side as a javascript. The TDA is open source under Apache License v2, which is compatible with the LGPL v3 license to be linked/called from the Support Tools.

I am willing to work on this enhancement, but first I would like to run it through you for your comments.

@AFaust
Copy link
Contributor

AFaust commented May 29, 2019

As we already have some other 3rd-party client-side JS libraries included for some tools, e.g. for the charts in the system performance tool, or for displaying data tables, I don't have any objection to including the Spotify thread dump analyzer per se. If I see it correctly from the GitHub repository, it would just be one JS file any maybe a CSS file, right? The license is compatible and there are no weird constructs in the source (shims / polyfills), so we could even maintain it / prepare PRs for it if there are some issues.

AFaust added a commit to AFaust/ootbee-support-tools that referenced this issue May 11, 2020
AFaust added a commit to AFaust/ootbee-support-tools that referenced this issue May 11, 2020
AFaust added a commit to AFaust/ootbee-support-tools that referenced this issue May 11, 2020
AFaust added a commit to AFaust/ootbee-support-tools that referenced this issue May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants