From 6b9fb400c09dabc2f0fa06a2e1b4e9df6f78fac8 Mon Sep 17 00:00:00 2001 From: PikachuEXE Date: Fri, 20 Feb 2015 23:06:55 +0800 Subject: [PATCH] ! Fix using throwable / spawn egg on container (e.g. enderchest) can bypass `use` permission node check --- .../java/ru/tehkode/modifyworld/handlers/PlayerListener.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/ru/tehkode/modifyworld/handlers/PlayerListener.java b/src/main/java/ru/tehkode/modifyworld/handlers/PlayerListener.java index c86845f..0284792 100644 --- a/src/main/java/ru/tehkode/modifyworld/handlers/PlayerListener.java +++ b/src/main/java/ru/tehkode/modifyworld/handlers/PlayerListener.java @@ -266,12 +266,12 @@ public void onPlayerInteract(PlayerInteractEvent event) { event.getPlayer().updateInventory(); } } - return; // no need to check further + break; // NEED to check further case MONSTER_EGG: // don't add MONSTER_EGGS here if (permissionDenied(player, "modifyworld.spawn", ((SpawnEgg)player.getItemInHand().getData()).getSpawnedType())) { event.setUseItemInHand(Result.DENY); } - return; // no need to check further + break; // NEED to check further } }