{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":715878832,"defaultBranch":"master","name":"PHP_CodeSniffer","ownerLogin":"PHPCSStandards","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-11-08T02:29:53.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/54010123?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726678000.0","currentOid":""},"activityList":{"items":[{"before":"8f520d3c3e9592d750c3576ca148546c5567e23e","after":"2488678e4b4d04af90af3a67961456b56c5ad193","ref":"refs/heads/4.0","pushedAt":"2024-09-18T16:48:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"PHP 8.4 | build-phar: remove use of `E_STRICT`\n\nThe `E_STRICT` constant is deprecated as of PHP 8.4 and will be removed in PHP 9.0.\n\nThe error level hasn't been in use since PHP 8.0 anyway, so removing the exclusion from the `error_reporting()` setting in the `build-phar` script should make no difference in practice.\n\nRef:\n* https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant","shortMessageHtmlLink":"PHP 8.4 | build-phar: remove use of <code>E_STRICT</code>"}},{"before":"15b5e02ba13cd5b018c9d4b4908f4fade6830ade","after":null,"ref":"refs/heads/feature/php-8.4-build-phar-e_strict","pushedAt":"2024-09-18T16:46:40.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"f735d4e1b481249beffbf6877e3a4dc769cd4b52","after":"92c8ef54357ea09d93f8efa043d7c9c0a71ae094","ref":"refs/heads/master","pushedAt":"2024-09-18T16:46:38.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #619 from PHPCSStandards/feature/php-8.4-build-phar-e_strict\n\nPHP 8.4 | build-phar: remove use of `E_STRICT`","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2534161186\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/619\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHP_CodeSniffer/pull/619/hovercard\" href=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/619\">#619</a> from PHPCSStandards/feature/php-8.4-build-pha…"}},{"before":"df82c4a9cfeaeb3b0a63c2c8917a10da788a3c28","after":"15b5e02ba13cd5b018c9d4b4908f4fade6830ade","ref":"refs/heads/feature/php-8.4-build-phar-e_strict","pushedAt":"2024-09-18T16:14:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"PHP 8.4 | build-phar: remove use of `E_STRICT`\n\nThe `E_STRICT` constant is deprecated as of PHP 8.4 and will be removed in PHP 9.0.\n\nThe error level hasn't been in use since PHP 8.0 anyway, so removing the exclusion from the `error_reporting()` setting in the `build-phar` script should make no difference in practice.\n\nRef:\n* https://wiki.php.net/rfc/deprecations_php_8_4#remove_e_strict_error_level_and_deprecate_e_strict_constant","shortMessageHtmlLink":"PHP 8.4 | build-phar: remove use of <code>E_STRICT</code>"}},{"before":null,"after":"df82c4a9cfeaeb3b0a63c2c8917a10da788a3c28","ref":"refs/heads/feature/php-8.4-build-phar-e_strict","pushedAt":"2024-09-18T16:11:20.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"build-phar: remove use of `E_STRICT`\n\nThe `E_STRICT` constant is deprecated as of PHP 8.4 and will be removed in PHP 9.0.\n\nThe error level hasn't been in use since PHP 8.0 anyway, so removing the exclusion from the `error_reporting()` setting in the `build-phar` script should make no difference in practice.","shortMessageHtmlLink":"build-phar: remove use of <code>E_STRICT</code>"}},{"before":"d802443e7d4bd8f29bce0d5bbd81aac31f175811","after":"1234504f93cac0b476464806c6c4584370428de6","ref":"refs/heads/feature/new-generic-heredocnowdocidentifierspacing-sniff","pushedAt":"2024-09-18T12:19:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":":sparkles: New `Generic.WhiteSpace.HereNowdocIdentifierSpacing` sniff\n\nNew `Generic.WhiteSpace.HereNowdocIdentifierSpacing` sniff which forbids whitespace between the `<<<` and the identifier string in heredoc/nowdoc start tokens.\n\nIncludes fixer.\nIncludes tests.\nIncludes XML docs.","shortMessageHtmlLink":"✨ New <code>Generic.WhiteSpace.HereNowdocIdentifierSpacing</code> sniff"}},{"before":"86982b0c9cc620846a816719981d908495f4a643","after":"659becb59ff029d60ff0d0af126ebfc51e5afa5f","ref":"refs/heads/feature/common-add-tests-and-simplify","pushedAt":"2024-09-18T12:18:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Common::getSniffCode(): minor simplification\n\n* Remove the use of `array_pop()` in favour of directly referencing the required \"parts\" by their index in the array.\n* Remove the unused `$sniffDir` variable.\n* Remove the unnecessary `$code` variable.\n\nRelated to [review comment in PR 446](https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/446#discussion_r1573947430).","shortMessageHtmlLink":"Common::getSniffCode(): minor simplification"}},{"before":"62d32998e820bddc40f99f8251958aed187a5c9c","after":"f735d4e1b481249beffbf6877e3a4dc769cd4b52","ref":"refs/heads/master","pushedAt":"2024-09-18T11:25:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Config: update version nr to next","shortMessageHtmlLink":"Config: update version nr to next"}},{"before":"929cea94a3fcfbe28ce7f16ddd67327c462a6b41","after":"697b0235287306b582032370aa039a9b78b9e35f","ref":"refs/heads/gh-pages","pushedAt":"2024-09-18T10:56:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Updated for 3.10.3 release","shortMessageHtmlLink":"Updated for 3.10.3 release"}},{"before":"60c52e0c8789a69b1d904e422e54b5ed3d7d6455","after":"8f520d3c3e9592d750c3576ca148546c5567e23e","ref":"refs/heads/4.0","pushedAt":"2024-09-18T10:40:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Changelog for the 3.10.3 release","shortMessageHtmlLink":"Changelog for the 3.10.3 release"}},{"before":"863be8cde9287a35e6fa2cf3fd0467dc4a140afc","after":null,"ref":"refs/heads/feature/changelog-3.10.3","pushedAt":"2024-09-18T10:39:00.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"28090747d909ab5d23c85994cfb6e0001e0ae39e","after":"62d32998e820bddc40f99f8251958aed187a5c9c","ref":"refs/heads/master","pushedAt":"2024-09-18T10:38:58.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #615 from PHPCSStandards/feature/changelog-3.10.3\n\nChangelog for the 3.10.3 release","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2532516261\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/615\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHP_CodeSniffer/pull/615/hovercard\" href=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/615\">#615</a> from PHPCSStandards/feature/changelog-3.10.3"}},{"before":null,"after":"863be8cde9287a35e6fa2cf3fd0467dc4a140afc","ref":"refs/heads/feature/changelog-3.10.3","pushedAt":"2024-09-18T01:50:32.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Changelog for the 3.10.3 release","shortMessageHtmlLink":"Changelog for the 3.10.3 release"}},{"before":"d24ade54562f5ef6fbf6864fe0249190da4d4873","after":"60c52e0c8789a69b1d904e422e54b5ed3d7d6455","ref":"refs/heads/4.0","pushedAt":"2024-09-18T01:12:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Docs: various minor fixes\n\n... picked up along the way.","shortMessageHtmlLink":"Docs: various minor fixes"}},{"before":"35e259b230d0d9bc74ae6867d91f4a5c462122fa","after":null,"ref":"refs/heads/feature/docs-various-fixes","pushedAt":"2024-09-18T01:12:01.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"335318f552418dfb8e474eae8e1034a3555d59b6","after":"28090747d909ab5d23c85994cfb6e0001e0ae39e","ref":"refs/heads/master","pushedAt":"2024-09-18T01:12:00.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #614 from PHPCSStandards/feature/docs-various-fixes\n\nDocs: various minor fixes","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2532447252\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/614\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHP_CodeSniffer/pull/614/hovercard\" href=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/614\">#614</a> from PHPCSStandards/feature/docs-various-fixes"}},{"before":null,"after":"35e259b230d0d9bc74ae6867d91f4a5c462122fa","ref":"refs/heads/feature/docs-various-fixes","pushedAt":"2024-09-18T00:43:41.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Docs: various minor fixes\n\n... picked up along the way.","shortMessageHtmlLink":"Docs: various minor fixes"}},{"before":"4a13db50cebaa7d1624292d577cfe292fd7c668e","after":"d24ade54562f5ef6fbf6864fe0249190da4d4873","ref":"refs/heads/4.0","pushedAt":"2024-09-16T11:29:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"GH Actions: Bump DavidAnson/markdownlint-cli2-action from 16 to 17\n\nBumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 16 to 17.\n- [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases)\n- [Commits](https://github.com/davidanson/markdownlint-cli2-action/compare/v16...v17)\n\n---\nupdated-dependencies:\n- dependency-name: DavidAnson/markdownlint-cli2-action\n  dependency-type: direct:production\n  update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"GH Actions: Bump DavidAnson/markdownlint-cli2-action from 16 to 17"}},{"before":"5bc630ca4ed8435048d086b4ea7e28408c2bd007","after":null,"ref":"refs/heads/dependabot/github_actions/DavidAnson/markdownlint-cli2-action-17","pushedAt":"2024-09-16T11:28:26.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"16b6f3554b7f0a7604ef65474d3bbb17cbdf6c5e","after":"335318f552418dfb8e474eae8e1034a3555d59b6","ref":"refs/heads/master","pushedAt":"2024-09-16T11:28:24.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #612 from PHPCSStandards/dependabot/github_actions/DavidAnson/markdownlint-cli2-action-17\n\nGH Actions: Bump DavidAnson/markdownlint-cli2-action from 16 to 17","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2527528568\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/612\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHP_CodeSniffer/pull/612/hovercard\" href=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/612\">#612</a> from PHPCSStandards/dependabot/github_actions…"}},{"before":null,"after":"5bc630ca4ed8435048d086b4ea7e28408c2bd007","ref":"refs/heads/dependabot/github_actions/DavidAnson/markdownlint-cli2-action-17","pushedAt":"2024-09-16T05:24:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"GH Actions: Bump DavidAnson/markdownlint-cli2-action from 16 to 17\n\nBumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 16 to 17.\n- [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases)\n- [Commits](https://github.com/davidanson/markdownlint-cli2-action/compare/v16...v17)\n\n---\nupdated-dependencies:\n- dependency-name: DavidAnson/markdownlint-cli2-action\n  dependency-type: direct:production\n  update-type: version-update:semver-major\n...\n\nSigned-off-by: dependabot[bot] <support@github.com>","shortMessageHtmlLink":"GH Actions: Bump DavidAnson/markdownlint-cli2-action from 16 to 17"}},{"before":"5716c8c756fe290cb42766a8798fa93b496198f3","after":"4a13db50cebaa7d1624292d577cfe292fd7c668e","ref":"refs/heads/4.0","pushedAt":"2024-09-14T10:43:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Squiz/DisallowMultipleAssignments: bug fix - dynamic property assignment on object stored in array\n\nThe sniff would try to find whether the first \"relevant\" variable found matches the start of the statement and if not, throw an error, but in the case of dynamic property access on objects stored in an array, the first \"relevant\" variable determination was off and would get stuck on the `]` close bracket of the array access.\n\nFixed now. Includes ample tests.\n\nThis should also make the sniff slightly more efficient for property access code snippets which the sniff already handled correctly.\n\nFixes 598","shortMessageHtmlLink":"Squiz/DisallowMultipleAssignments: bug fix - dynamic property assignm…"}},{"before":"0ab692aba09f4483ae0bea416421f4354a7801f3","after":null,"ref":"refs/heads/feature/598-squiz-disallowmultipleassignments-bug-fix","pushedAt":"2024-09-14T10:32:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"b87dafdb1ea1c16887c8e5048513fd6952d8269d","after":"16b6f3554b7f0a7604ef65474d3bbb17cbdf6c5e","ref":"refs/heads/master","pushedAt":"2024-09-14T10:32:46.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #610 from PHPCSStandards/feature/598-squiz-disallowmultipleassignments-bug-fix\n\nSquiz/DisallowMultipleAssignments: bug fix - dynamic property assignment on object stored in array","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2512535842\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/610\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHP_CodeSniffer/pull/610/hovercard\" href=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/610\">#610</a> from PHPCSStandards/feature/598-squiz-disallo…"}},{"before":"539687259815210a116f52fdef2b75d9c10c5b1b","after":"0ab692aba09f4483ae0bea416421f4354a7801f3","ref":"refs/heads/feature/598-squiz-disallowmultipleassignments-bug-fix","pushedAt":"2024-09-14T10:05:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Squiz/DisallowMultipleAssignments: bug fix - dynamic property assignment on object stored in array\n\nThe sniff would try to find whether the first \"relevant\" variable found matches the start of the statement and if not, throw an error, but in the case of dynamic property access on objects stored in an array, the first \"relevant\" variable determination was off and would get stuck on the `]` close bracket of the array access.\n\nFixed now. Includes ample tests.\n\nThis should also make the sniff slightly more efficient for property access code snippets which the sniff already handled correctly.\n\nFixes 598","shortMessageHtmlLink":"Squiz/DisallowMultipleAssignments: bug fix - dynamic property assignm…"}},{"before":"5b99d35fec3c937bb32b32a82b343001a78cce4b","after":"5716c8c756fe290cb42766a8798fa93b496198f3","ref":"refs/heads/4.0","pushedAt":"2024-09-14T10:05:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Squiz/MultiLineFunctionDeclaration: bug fix - skip over attributes\n\nThe sniff looks for `T_COMMA` tokens to find the start of the next parameter and skips over parenthesis sets and square brackets sets (like short arrays) to prevent mismatching on a `T_COMMA` which is not a parameter separator.\n\nThis logic did not take parameter attributes into account, which can contain multiple comma-separated attributes, so should also be skipped over.\n\nFixed now. Includes plenty of tests.\n\nAlso includes minor stability fix for the parentheses/square brackets skipping.\n\nNotes:\n* It could be argued that the sniff should use the `File::getMethodParameters()` method to do the parameter parsing instead. This could be done in a future iteration, but will need to be evaluated carefully for side-effects.\n* This sniff extends the PEAR `FunctionDeclaration` sniff. It has been verified that that sniff is not affected by this bug.\n\nFixes 608","shortMessageHtmlLink":"Squiz/MultiLineFunctionDeclaration: bug fix - skip over attributes"}},{"before":"f39847a55d104adb714e186ecdb6e4d8599b3cda","after":null,"ref":"refs/heads/feature/608-squiz-multilinefunctiondeclarations-bug-fix-param-attributes","pushedAt":"2024-09-14T09:58:21.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}},{"before":"c0e8f4de2884a52af95ee4f516e247ff1048413b","after":"b87dafdb1ea1c16887c8e5048513fd6952d8269d","ref":"refs/heads/master","pushedAt":"2024-09-14T09:58:20.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Merge pull request #609 from PHPCSStandards/feature/608-squiz-multilinefunctiondeclarations-bug-fix-param-attributes\n\nSquiz/MultiLineFunctionDeclaration: bug fix - skip over attributes","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2512442744\" data-permission-text=\"Title is private\" data-url=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/609\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/PHPCSStandards/PHP_CodeSniffer/pull/609/hovercard\" href=\"https://github.com/PHPCSStandards/PHP_CodeSniffer/pull/609\">#609</a> from PHPCSStandards/feature/608-squiz-multili…"}},{"before":"0da0b784870531183220a432c4078575b4f34f1d","after":"f39847a55d104adb714e186ecdb6e4d8599b3cda","ref":"refs/heads/feature/608-squiz-multilinefunctiondeclarations-bug-fix-param-attributes","pushedAt":"2024-09-14T09:30:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"},"commit":{"message":"Squiz/MultiLineFunctionDeclaration: bug fix - skip over attributes\n\nThe sniff looks for `T_COMMA` tokens to find the start of the next parameter and skips over parenthesis sets and square brackets sets (like short arrays) to prevent mismatching on a `T_COMMA` which is not a parameter separator.\n\nThis logic did not take parameter attributes into account, which can contain multiple comma-separated attributes, so should also be skipped over.\n\nFixed now. Includes plenty of tests.\n\nAlso includes minor stability fix for the parentheses/square brackets skipping.\n\nNotes:\n* It could be argued that the sniff should use the `File::getMethodParameters()` method to do the parameter parsing instead. This could be done in a future iteration, but will need to be evaluated carefully for side-effects.\n* This sniff extends the PEAR `FunctionDeclaration` sniff. It has been verified that that sniff is not affected by this bug.\n\nFixes 608","shortMessageHtmlLink":"Squiz/MultiLineFunctionDeclaration: bug fix - skip over attributes"}},{"before":"4600d9edfe7ea31aeea339498f18c446b1f3450d","after":null,"ref":"refs/heads/dependabot/github_actions/peter-evans/create-pull-request-7","pushedAt":"2024-09-09T20:17:07.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"jrfnl","name":"Juliette","path":"/jrfnl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/663378?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEufMFtwA","startCursor":null,"endCursor":null}},"title":"Activity · PHPCSStandards/PHP_CodeSniffer"}