Skip to content

Commit 8bc18b4

Browse files
okonomiyaki3000hopeseekr
authored andcommitted
Update the docblock return value, always return , use empty instead of count, use array_map instead of foreach, call isset with multiple args
1 parent de8a354 commit 8bc18b4

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

ChromePhp.php

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -244,29 +244,25 @@ public static function table()
244244
* internal logging call
245245
*
246246
* @param string $type
247-
* @return void
247+
* @return ChromePhp
248248
*/
249249
protected static function _log($type, array $args)
250250
{
251+
$logger = self::getInstance();
252+
251253
// nothing passed in, don't do anything
252-
if (count($args) == 0 && $type != self::GROUP_END) {
253-
return;
254+
if (empty($args) && $type != self::GROUP_END) {
255+
return $logger;
254256
}
255257

256-
$logger = self::getInstance();
257-
258258
$logger->_processed = array();
259-
260-
$logs = array();
261-
foreach ($args as $arg) {
262-
$logs[] = $logger->_convert($arg);
263-
}
259+
$logs = array_map(array($logger, '_convert'), $args);
264260

265261
$backtrace = debug_backtrace(false);
266262
$level = $logger->getSetting(self::BACKTRACE_LEVEL);
267263

268264
$backtrace_message = 'unknown';
269-
if (isset($backtrace[$level]['file']) && isset($backtrace[$level]['line'])) {
265+
if (isset($backtrace[$level]['file'], $backtrace[$level]['line'])) {
270266
$backtrace_message = $backtrace[$level]['file'] . ' : ' . $backtrace[$level]['line'];
271267
}
272268

0 commit comments

Comments
 (0)