-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can you help me interpret mozilla rating of phpfox for some fixes ? #2907
Comments
I improved it manually adding the following to the beginning of index.php:
I also added this to .htaccess to cover all other settings:
I guess the phpfox team could add that easily settings in the core. Some of them apply only if the website is set up for HTTPS. However, the maximum rating you will get with this is a B. phpfox uses currently a lot of inline javascript code, which makes it insecure per definition. They should stop using this bad practice and use only external javascript code. For generating javascript code from PHP (for example, for text translations) they could simply use an external script handler:
The same applies for inline CSS. |
Daniol, you are a genius! Thanks. |
@harrison05 are you guys working on better handling javascript code, and do some changes so we can have faster load times and less browser errors ? |
Important
Please follow this template!
What's happened?
...
I found mozilla site that grades the phpfox script / demo site
can you interpret if we need to be adding or deleting some things to create a better and safer experience for admins and users of phpfox
Steps to reproduce:
What's expected?
... seems they rate the site of demo poorly can we improve this somehow ?
Browsers and Devices tested
(Example: Chrome on iPhone X, Safari on Macbook, Miscrosoft Edge on Windown 10, Firefox on Ubuntu 16.04, ...)
...
Server information
(Example: CentOS 7, php 7.1 apache)
...
phpFox version
(Example: phpFox 4.6.0)
... your demo site
Screenshots
...
The text was updated successfully, but these errors were encountered: