Caster calibration controller can calibrate wrong way with user input (ros ticket #3841)

[ahendrix]

I tried to "help" the casters on PRM calibrate with the motors halted. I spun one the wrong way and it calibrated backwards. Since we're now using upper and lower limits in the calibration flag position, we should not trip the calibration controller until we cross the correct flag.

pr2_calibration_controllers/src/caster_calibration_controller.cpp
{{{
bool switch_state_ = actuator_->state_.calibration_reading_ & 1;
if (switch_state_ != original_switch_state_)
{
}}}

This should check whether we trip the rising or falling edge, and only trigger in that case.

trac data:

• Owner: wim
• Reporter: watts
• Reported at: Tue Feb 9 16:20:26 2010
• URL: https://code.ros.org/trac/wg-ros-pkg/ticket/3841

[ahendrix]

[watts] This has happened on a texas robot. We've confirmed this on ta113.

We checked the launch files, and verified that our input was correct.

The caster calibration controller needs to be fixed.

[ahendrix]

[wim] To know which of the two flags you hit, you need to know 2 things:

• did you see a rising or falling edge
• did you move in the positive or negative direction when the flag was triggered

The problem described in this ticket seems caused by assuming the caster moves in one direction, but a user is pushing it in the other direction.

[ahendrix]

[wim] Fixed in trunk.

wim@prl1:~/boxturtle_wg_all/stacks/pr2_controllers/pr2_calibration_controllers$ svn ci -m "check if calibration happens on correct flag. ticket 3841. check applies to joint and caster calibration controllers"
Sending include/pr2_calibration_controllers/caster_calibration_controller.h
Sending include/pr2_calibration_controllers/joint_calibration_controller.h
Sending src/caster_calibration_controller.cpp
Sending src/joint_calibration_controller.cpp
Transmitting file data ....
Committed revision r36024.

[ahendrix]

[dking] This change adds a ros::Duration(1.0).sleep() which kills the realtime loop every time this scenario is hit. The proper way to add a delay to the update function would be to add another state to state machine.