Skip to content

NMEA velocity rate count issue - possible duplicate message handling #185

@NearDuckyu

Description

@NearDuckyu

I've noticed what appears to be a minor issue while using the GNSS module with NMEA data output.

  • While using the NMEA driver, I've noticed that the velocity publish rate appears to be twice the position publish rate
    • The NMEA data itself seems quite normal (RMC, GGA, GLL, VTG messages are present with expected ratios)
    • I believe the rate_count_vel might not be counted as intended

I've been comparing two sections of code and noticed a difference that might be relevant:
Line 562-566: if (!_VEL_received && (_last_VEL_timeUTC < utc_time)) { ..... _rate_count_vel++;.....}
Line 890-904: if (!_unicore_parser.agricaValid()) { ..... _rate_count_vel++;.....}

If my understanding is correct, perhaps line 890~904 could also include a check like:
!_VEL_received && (_last_VEL_timeUTC < utc_time) for counting the _rate_count_vel condition similar to how Line 562 handles it.
This might help ensure that velocity messages are processed only once per unique position data publish iteration.

If I've misunderstood something or if there's a better approach, I'd be pleased to discuss about it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions