Skip to content

Commit 602bc38

Browse files
LocalIdentityLocalIdentity
andauthored
Fix Multistrike + Awakened Spell Echo not working properly with minions (#8771)
Multistrike would only add repeats to skills with the tag on it which broke support for minions skills It now uses the same criteria that the damage mods do This also made me realise that the repeat damage config was not working when used with minion skills as we were only setting the condition on the player So the average repeat damage and final repeat values were completely wrong and the double damage with spells line on Awakened Spell Echo was not working at all with minions Co-authored-by: LocalIdentity <localidentity2@gmail.com>
1 parent 4fb62fa commit 602bc38

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/Data/SkillStatMap.lua

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,8 @@ return {
266266
mod("RepeatCount", "BASE", nil, 0, 0, {type = "SkillType", skillType = SkillType.Multicastable }),
267267
},
268268
["base_melee_attack_repeat_count"] = {
269-
mod("RepeatCount", "BASE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Multistrikeable }),
269+
mod("RepeatCount", "BASE", nil, 0, 0, { type = "ModFlagOr", modFlags = bit.bor(ModFlag.WeaponMelee, ModFlag.Unarmed) }),
270+
mod("RepeatCount", "BASE", nil, 0, 0, { type = "SkillType", skillType = SkillType.RequiresShield }),
270271
},
271272
["skill_repeat_count"] = {
272273
mod("RepeatCount", "BASE", nil, 0, 0, { type = "SkillType", skillType = SkillType.Multicastable }),

src/Modules/ConfigOptions.lua

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -844,8 +844,10 @@ Huge sets the radius to 11.
844844
}, defaultIndex = 2, apply = function(val, modList, enemyModList)
845845
if val == "AVERAGE" then
846846
modList:NewMod("Condition:averageRepeat", "FLAG", true, "Config")
847+
modList:NewMod("MinionModifier", "LIST", { mod = modLib.createMod("Condition:averageRepeat", "FLAG", true, "Config") })
847848
elseif val == "FINAL" or val == "FINAL_DPS" then
848849
modList:NewMod("Condition:alwaysFinalRepeat", "FLAG", true, "Config")
850+
modList:NewMod("MinionModifier", "LIST", { mod = modLib.createMod("Condition:alwaysFinalRepeat", "FLAG", true, "Config") })
849851
end
850852
end },
851853
{ var = "ruthlessSupportMode", type = "list", label = "Ruthless Support Mode:", ifSkill = "Ruthless", tooltip = "Controls how the hit/ailment effect of Ruthless Support is calculated:\n\tAverage: damage is based on the average application\n\tMax Effect: damage is based on maximum effect", list = {{val="AVERAGE",label="Average"},{val="MAX",label="Max Effect"}} },

0 commit comments

Comments
 (0)