Skip to content

Commit ae2e2fd

Browse files
author
LocalIdentity
committed
Fix Cast on Crit and other secondary granted effects
Secondary granted effects from supports like cast on crit or cast when damage taken weren't working as we were not adding the secondary granted effects
1 parent 874d423 commit ae2e2fd

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

src/Modules/CalcSetup.lua

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1516,7 +1516,12 @@ function calcs.initEnv(build, mode, override, specEnv)
15161516
end
15171517
-- if the slot has an imbued support, add it as an ExtraSupport
15181518
if build.skillsTab.imbuedSupportBySlot and build.skillsTab.imbuedSupportBySlot[slotName] and group.imbuedSupport then
1519-
addExtraSupports(nil, build.skillsTab.imbuedSupportBySlot[slotName], 1)
1519+
local imbuedSupport = build.skillsTab.imbuedSupportBySlot[slotName]
1520+
addExtraSupports(nil, imbuedSupport, 1)
1521+
local imbuedGemData = env.data.gems[env.data.gemForSkill[imbuedSupport]]
1522+
if imbuedGemData and imbuedGemData.secondaryGrantedEffect and imbuedGemData.secondaryGrantedEffect.support then
1523+
addExtraSupports(nil, imbuedGemData.secondaryGrantedEffect, 1)
1524+
end
15201525
end
15211526

15221527
for gemIndex, gemInstance in ipairs(group.gemList) do

0 commit comments

Comments
 (0)