-
Notifications
You must be signed in to change notification settings - Fork 16
Enhance Site Navigation: Add Search Bar to Navbar #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is a great idea. If implemented, I think it would be of limited use if the scope only included the webpage content itself. What would be particularly useful is if it included the Develop Branch of the Documentation. I am not sure how difficult this will be, but it would also be great to update (#18) and index our package documentation. |
@dlebauer Okay, I understand. I'll look into including the Develop Branch and indexing the package documentation. Thanks for the feedback! |
Thanks @divine7022 ! Just to be clear, I meant 'the develop branch of the documentation' ... not the entire develop branch (though once #18 is implemented it would be great to include that as well). |
@dlebauer Got it! Thank you |
@dlebauer Let me know if you have any specific requirements or suggestions! |
Can you update this branch with a POC video ? |
@allgandalf Hello sir Thank you for feedback! I initially used a local search library, which worked for searching static site content like blogs, publications, and the about page. However, it couldn't search the documentation content since the documentation is rendered from the pecan-documentation repository, which is built by To address this, I integrated Algolia's crawler to index both:
However, I encountered two issues:
|
Untitled.video.-.Made.with.Clipchamp.2.mp4Untitled.video.-.Made.with.Clipchamp.3.mp4
|
@allgandalf |
@divine7022 using algolia would cost us $$, i don't think so we want to go down with that appraoch |
@allgandalf and @divine7022 could the free tier could meet our needs https://www.algolia.com/pricing ? I doubt we will get anywhere near 10k searches/ month. |
I do not trust their free tier to be free. From the pricing FAQ: "Search operations are triggered when a search is performed. In autocomplete and search-as-you-type implementations, a new search request is performed on every keystroke." 😬 |
@infotroph did you check if we can trigger the search on debounced inputs ? a timeout of say 2 seconds after the user has stopped typing would help |
No, and I do not plan to spend more time on it. PEcAn is built to be reliably free for everyone; Trying to find loopholes to use paid services for free is a bad use of our time. |
fair pointtttt |
It seems to be a good idea. Using a debounced input with a 2-second delay before sending a request could significantly reduce the number of API calls, preventing unnecessary searches on every keystroke. This might help us stay within the free tier limits. However, we'd need to test how well it works in practice. |
@divine7022 lets get away from using 3rd party tool, try if you can find any open source tool for this, else we should focus on what we can do now with the available resources |
Hello @allgandalf, Let me know if you have any preferences regarding potential solutions. Thanks! |
To improve site navigation and make it easier for users to find information, this issue proposes adding a search bar to the main navigation bar. This will allow users to quickly search the site's content.
The text was updated successfully, but these errors were encountered: