stderr handling

Author: Daniel Wirtz

ClosureCompiler.js

@@ -32,7 +32,7 @@
 
     /**
      * Constructs a new ClosureCompiler.
-     * @exports ClosureCompiler
+     * @exports ClosureCompiler.
      * @class Bindings for Closure Compiler.
      * @constructor
      */
@@ -126,7 +126,8 @@
      * @param {Object.<string,*|Array>} options Any options Closure Compiler supports. If an option can occur
      *  multiple times, simply supply an array. Externs can additionally point to a directory to include all *.js files 
      *  in it.
-     * @param {function(Error,string)} callback Callback called with the error, if any, and the compiled code
+     * @param {function((Error|string),string)} callback Callback called with the error, if any, and the compiled code.
+     *  If no error occurred, error contains the string output from stderr besides the result.
      * @throws {Error} If the file cannot be compiled
      * @expose
      */
@@ -223,12 +224,10 @@
         // Run it     
         function run(java, args) {
             exec('"'+java+'" '+args, function(error, stdout, stderr) {
-                if (stderr.length > 0) {
-                    callback(new Error(""+stderr), null)
-                } else if (error) {
-                    callback(error, null);
+                if (stdout.length > 0 || stderr.length > 0) { // If we get output, error basically just contains a copy of stderr
+                    callback(stderr+"", stdout+"");
                 } else {
-                    callback(null, ""+stdout);
+                    callback(error, null);
                 }
             });
         }

ClosureCompiler.min.js

@@ -78,16 +78,18 @@ for (var i=2; i<process.argv.length; i++) {
 
 // Run it
 ClosureCompiler.compile(files, options, function(error, result) {
-    if (help) {
-        help = error.message;
-        help = help.replace(/(\-\-[a-zA-Z0-9_]+) ([^ ])/g, function($, $1, $2) {
+    if (help && typeof error == 'string') {
+        error = error.replace(/(\-\-[a-zA-Z0-9_]+) ([^ ])/g, function($, $1, $2) {
             return $1+"="+$2;
         });
         console.error("ClosureCompiler.js "+pkg.version+" - https://github.com/dcodeIO/ClosureCompiler.js\n");
         console.error("  Usage:   "+path.basename(process.argv[1])+" sourceFiles ... [--option=value --flagOption ...] [> outFile]\n");
-        console.error(help);
-        process.exit(0);
+        console.error(error);
+        process.exit(1);
     }
-    if (error) throw(error);
+    if (error instanceof Error) {
+        throw(error);
+    }
+    process.stderr.write(error);
     process.stdout.write(result);
 });