Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Jun 2, 2025

Builds on #545.

Changes proposed in this pull request

  • For multi-PLD PCASL data, calculate CBF and ATT using the weighted average approach, then pass those arrays into the GKM method as initial estimates for those variables.

@tsalo tsalo added enhancement New feature or request breaking-change PRs that change results or interfaces. labels Jun 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025

Codecov Report

❌ Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.23%. Comparing base (b51c487) to head (d433a31).

Files with missing lines Patch % Lines
aslprep/utils/cbf.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   75.09%   75.23%   +0.14%     
==========================================
  Files          38       38              
  Lines        4578     4600      +22     
==========================================
+ Hits         3438     3461      +23     
+ Misses       1140     1139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tsalo
Copy link
Member Author

tsalo commented Jun 2, 2025

Using the weighted-average CBF and ATT as priors doesn't seem to help in our test dataset.
image

@tsalo tsalo marked this pull request as draft June 2, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change PRs that change results or interfaces. enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants