From b82137cf59b1674ccf72e595d688deaea89d9106 Mon Sep 17 00:00:00 2001
From: Tim Clephas <tim.clephas@nobleo.nl>
Date: Tue, 25 Mar 2025 14:13:53 +0100
Subject: [PATCH] No need to default-construct logger in the declaration

---
 .../jinja_templates/cpp/parameter_library_header      | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/generate_parameter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header b/generate_parameter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header
index 179d506..fa4e36f 100644
--- a/generate_parameter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header
+++ b/generate_parameter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header
@@ -105,9 +105,9 @@ struct StackParams {
     }
 
     ParamListener(const std::shared_ptr<rclcpp::node_interfaces::NodeParametersInterface>& parameters_interface,
-                  rclcpp::Logger logger, std::string const& prefix = "") {
-      logger_ = std::move(logger);
-      prefix_ = prefix;
+                  rclcpp::Logger logger, std::string const& prefix = "")
+    : logger_{std::move(logger)},
+      prefix_{prefix} {
       if (!prefix_.empty() && prefix_.back() != '.') {
         prefix_ += ".";
       }
@@ -220,10 +220,7 @@ struct StackParams {
       std::shared_ptr<rclcpp::node_interfaces::OnSetParametersCallbackHandle> handle_;
       std::shared_ptr<rclcpp::node_interfaces::NodeParametersInterface> parameters_interface_;
 
-      // rclcpp::Logger cannot be default-constructed
-      // so we must provide a initialization here even though
-      // every one of our constructors initializes logger_
-      rclcpp::Logger logger_ = rclcpp::get_logger("{{namespace}}");
+      rclcpp::Logger logger_;
       std::mutex mutable mutex_;
   };