Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Components] fileforge #13975

Closed
pipedream-component-development opened this issue Sep 17, 2024 · 3 comments · Fixed by #13989
Closed

[Components] fileforge #13975

pipedream-component-development opened this issue Sep 17, 2024 · 3 comments · Fixed by #13989
Assignees
@luancazarine
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@pipedream-component-development
Copy link
Collaborator

pipedream-component-development commented Sep 17, 2024 •
edited by luancazarine
Loading

fileforge

URLs

Actions

generate-pdf

Prompt

Generate a PDF from provided HTML. The required prop should include 'files', which are the HTML files to convert. Optional props are: 'test', 'host', 'expiresAt', 'fileName' and 'allowViewing'. This is a powerful feature for those wanting to quickly generate a PDF document.

URLs
@luancazarine luancazarine self-assigned this Sep 18, 2024
@luancazarine luancazarine mentioned this issue Sep 18, 2024
Merged
luancazarine added a commit that referenced this issue Sep 18, 2024
@luancazarine
[Components] fileforge #13975
81fa82a 
Actions
 - Generate PDF
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/Components-fileforge-106bf548bb5e81cea66dd3cea386d303

@vunguyenhung vunguyenhung added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Sep 19, 2024
@luancazarine
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information https://vunguyenhung.notion.site/Components-fileforge-106bf548bb5e81cea66dd3cea386d303

Hi @vunguyenhung,
The 'allow viewing' prop allows you to choose whether the file will be accessible from outside or not.
The 'expiresAt' prop allows you to specify until when the file will be available for use, regardless of whether 'allow viewing' is enabled or not.
so I don't think they are not redundant

@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Components-fileforge-106bf548bb5e81cea66dd3cea386d303

luancazarine added a commit that referenced this issue Sep 20, 2024
@luancazarine
New Components - fileforge (#13989)
d83f8ee 
* fileforge init

* [Components] fileforge #13975
Actions
 - Generate PDF

* pnpm update

* some adjusts

* add form-data

* pnpm update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luancazarine luancazarine

Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
Component (Source and Action) Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New Components - fileforge PipedreamHQ/pipedream
3 participants
@luancazarine @vunguyenhung @pipedream-component-development