Revert "Set guidata validation mode to STRICT in tests"

PierreRaybaut · PierreRaybaut · commit 312d98cad76d · 2025-08-02T15:05:52.000+02:00
This reverts commit 0d51903.
diff --git a/plotpy/config.py b/plotpy/config.py
diff --git a/plotpy/items/shape/axis.py b/plotpy/items/shape/axis.py
@@ -49,7 +49,7 @@ def __init__(
     ) -> None:
         super().__init__(shapeparam=shapeparam)
         self.set_rect(p0, p1, p2)
-        self.arrow_angle = 15.0  # degrees
+        self.arrow_angle = 15  # degrees
         self.arrow_size = 0.05  # % of axe length
         self.x_pen = self.pen
         self.x_brush = self.brush
diff --git a/plotpy/styles/axes.py b/plotpy/styles/axes.py
@@ -46,8 +46,8 @@ class AxisParam(DataSet):
     scale = ChoiceItem(
         _("Scale"), [("lin", _("linear")), ("log", _("logarithmic"))], default="lin"
     )
-    vmin = FloatItem("Min", help=_("Lower axis limit"), default=0.0)
-    vmax = FloatItem("Max", help=_("Upper axis limit"), default=1.0)
+    vmin = FloatItem("Min", help=_("Lower axis limit"))
+    vmax = FloatItem("Max", help=_("Upper axis limit"))
 
     def update_param(self, plot: BasePlot, axis_id: int) -> None:
         """
diff --git a/plotpy/styles/base.py b/plotpy/styles/base.py
@@ -373,7 +373,7 @@ def update_param(self, symb):
             self.marker = MARKER_NAME[symb]
             return
         self.marker = MARKER_NAME[symb.style()]
-        self.size = int(symb.size().width())
+        self.size = symb.size().width()
         self.edgecolor = str(symb.pen().color().name())
         self.facecolor = str(symb.brush().color().name())
 
@@ -420,7 +420,7 @@ class SymbolItem(ObjectItem):
 class LineStyleParam(DataSet):
     style = ImageChoiceItem(_("Style"), LINESTYLE_CHOICES, default="SolidLine")
     color = ColorItem(_("Color"), default="black")
-    width = FloatItem(_("Width"), default=1.0, min=0.0)
+    width = FloatItem(_("Width"), default=1.0, min=0)
 
     def update_param(self, pen):
         """
diff --git a/plotpy/styles/curve.py b/plotpy/styles/curve.py
@@ -39,7 +39,7 @@ class CurveParam(DataSet):
     )
     line = LineStyleItem(_("Line"))
     symbol = SymbolItem(_("Symbol"))
-    shade = FloatItem(_("Shadow"), default=0.0, min=0.0, max=1.0)
+    shade = FloatItem(_("Shadow"), default=0, min=0, max=1)
     curvestyle = ImageChoiceItem(_("Curve style"), CURVESTYLE_CHOICES, default="Lines")
     baseline = FloatItem(_("Baseline"), default=0.0)
     _use_dsamp_prop = GetAttrProp("use_dsamp")
diff --git a/plotpy/styles/errorbar.py b/plotpy/styles/errorbar.py
@@ -30,7 +30,7 @@ class ErrorBarParam(DataSet):
     alpha = FloatItem(
         _("Alpha"), default=0.9, min=0, max=1, help=_("Error bar transparency")
     )
-    width = FloatItem(_("Width"), default=1.0, min=1.0)
+    width = FloatItem(_("Width"), default=1.0, min=1)
     cap = IntItem(_("Cap"), default=4, min=0)
     ontop = BoolItem(_("set to foreground"), _("Visibility"), default=False)
 
diff --git a/plotpy/styles/image.py b/plotpy/styles/image.py
@@ -433,7 +433,7 @@ class MaskedImageParamMixin(DataSet):
     """Mixin for masked image parameters."""
 
     g_mask = BeginGroup(_("Mask"))
-    filling_value = FloatItem(_("Filling value"), default=0.0)
+    filling_value = FloatItem(_("Filling value"))
     show_mask = BoolItem(_("Show image mask"), default=False)
     alpha_masked = FloatItem(_("Masked area alpha"), default=0.7, min=0, max=1)
     alpha_unmasked = FloatItem(_("Unmasked area alpha"), default=0.0, min=0, max=1)
@@ -501,10 +501,10 @@ class ImageFilterParam(BaseImageParam):
 
     label = StringItem(_("Title"), default=_("Filter"))
     g1 = BeginGroup(_("Bounds"))
-    xmin = FloatItem(_("x|min"), default=0.0)
-    xmax = FloatItem(_("x|max"), default=1.0)
-    ymin = FloatItem(_("y|min"), default=0.0)
-    ymax = FloatItem(_("y|max"), default=1.0)
+    xmin = FloatItem(_("x|min"))
+    xmax = FloatItem(_("x|max"))
+    ymin = FloatItem(_("y|min"))
+    ymax = FloatItem(_("y|max"))
     _g1 = EndGroup("sub-group")
     use_source_cmap = BoolItem(
         _("Use image colormap and level"), _("Color map"), default=True
diff --git a/plotpy/styles/label.py b/plotpy/styles/label.py
@@ -47,9 +47,7 @@ class LabelParam(DataSet):
     ___cont = BeginGroup(_("Contents")).set_prop(
         "display", icon="label.png", hide=GetAttrProp("_no_contents")
     )
-    contents = TextItem("", default="").set_prop(
-        "display", hide=GetAttrProp("_no_contents")
-    )
+    contents = TextItem("").set_prop("display", hide=GetAttrProp("_no_contents"))
     ___econt = EndGroup(_("Contents")).set_prop(
         "display", hide=GetAttrProp("_no_contents")
     )
diff --git a/plotpy/styles/shape.py b/plotpy/styles/shape.py
@@ -235,12 +235,8 @@ def update_shape(self, obj: PolygonShape) -> None:
 class AxesShapeParam(DataSet):
     """Parameters for an axes item"""
 
-    arrow_angle = FloatItem(
-        _("Arrow angle") + " (°)", min=0.0, max=90.0, default=15.0, nonzero=True
-    )
-    arrow_size = FloatItem(
-        _("Arrow size") + " (%)", min=0.0, max=100.0, default=0.05, nonzero=True
-    )
+    arrow_angle = FloatItem(_("Arrow angle") + " (°)", min=0, max=90, nonzero=True)
+    arrow_size = FloatItem(_("Arrow size") + " (%)", min=0, max=100, nonzero=True)
     _styles = BeginTabGroup("Styles")
     # ------------------------------------------------------------------ Line tab
     ___line = BeginGroup(_("Line")).set_prop("display", icon="dashdot.png")
diff --git a/plotpy/tests/conftest.py b/plotpy/tests/conftest.py
@@ -12,14 +12,10 @@
 import qwt
 import scipy
 import tifffile
-from guidata.config import ValidationMode, set_validation_mode
 from guidata.env import execenv
 
 import plotpy
 
-# Set validation mode to STRICT for the sigima package
-set_validation_mode(ValidationMode.STRICT)
-
 # Turn on unattended mode for executing tests without user interaction
 execenv.unattended = True
 execenv.verbose = "quiet"
diff --git a/plotpy/tests/features/test_image_coords.py b/plotpy/tests/features/test_image_coords.py
@@ -29,8 +29,8 @@ def test_pixel_coords():
     with qt_app_context(exec_loop=True):
         image = make.image(data, interpolation="nearest")
         text = "First pixel should be centered on (0, 0) coordinates"
-        label = make.label(text, (1.0, 1.0), (0, 0), "L")
-        rect = make.rectangle(5.0, 5.0, 10.0, 10.0, "Rectangle")
+        label = make.label(text, (1, 1), (0, 0), "L")
+        rect = make.rectangle(5, 5, 10, 10, "Rectangle")
         cursors = []
         for i_cursor in range(0, 21, 10):
             cursors.append(make.vcursor(i_cursor, movable=False))
diff --git a/plotpy/tests/features/test_image_filter.py b/plotpy/tests/features/test_image_filter.py
@@ -53,7 +53,7 @@ def test_imagefilter():
     data = io.imread(filename, to_grayscale=True)
     x = np.linspace(0, 30.0, data.shape[1])
     y = np.linspace(0, 30.0, data.shape[0])
-    imshow(x, y, data, filter_area=(10.0, 20.0, 5.0, 15.0))
+    imshow(x, y, data, filter_area=(10, 20, 5, 15))
 
 
 if __name__ == "__main__":
diff --git a/plotpy/tests/unit/test_manipulate_selection.py b/plotpy/tests/unit/test_manipulate_selection.py
@@ -291,11 +291,11 @@ def test_rectangular_selection():
     with qt_app_context(exec_loop=False):
         items = [
             make.image(gen_image4(100, 100)),
-            make.trimage(gen_image4(100, 100), x0=100.0, y0=100.0),
-            make.curve(np.arange(100), 100.0 + 20.0 * np.cos(np.arange(100))),
-            make.annotated_rectangle(50.0, 50.0, 100.0, 100.0),
+            make.trimage(gen_image4(100, 100), x0=100, y0=100),
+            make.curve(np.arange(100), 100 + 20 * np.cos(np.arange(100))),
+            make.annotated_rectangle(50, 50, 100, 100),
             make.legend(),
-            make.label("Test", (100.0, 100.0), (0, 0), "R"),
+            make.label("Test", (100, 100), (0, 0), "R"),
         ]
 
         is_rect_selectable = [
diff --git a/plotpy/tests/widgets/test_dotarraydemo.py b/plotpy/tests/widgets/test_dotarraydemo.py
@@ -49,16 +49,14 @@ def _update_cb(self, *args):
         pass
 
     g1 = gds.BeginGroup("Size of the area")
-    dim_h = gds.FloatItem("Width", default=20.0, min=0.0, unit="mm")
-    dim_v = gds.FloatItem("Height", default=20.0, min=0.0, unit="mm")
+    dim_h = gds.FloatItem("Width", default=20, min=0, unit="mm")
+    dim_v = gds.FloatItem("Height", default=20, min=0, unit="mm")
     _g1 = gds.EndGroup("Size of the area")
 
     g2 = gds.BeginGroup("Grid pattern properties")
-    step_x = gds.FloatItem("Step in X-axis", default=1.0, min=1.0, unit="mm")
-    step_y = gds.FloatItem("Step in Y-axis", default=1.0, min=1.0, unit="mm")
-    size = gds.FloatItem(
-        "Dot size", default=0.2, min=0.0, max=2.0, slider=True, unit="mm"
-    )
+    step_x = gds.FloatItem("Step in X-axis", default=1, min=1, unit="mm")
+    step_y = gds.FloatItem("Step in Y-axis", default=1, min=1, unit="mm")
+    size = gds.FloatItem("Dot size", default=0.2, min=0, max=2, slider=True, unit="mm")
     color = gds.ColorItem("Dot color", default="red")
     _g2 = gds.EndGroup("Grid pattern properties")
 
diff --git a/plotpy/tests/widgets/test_simple_dialog.py b/plotpy/tests/widgets/test_simple_dialog.py
@@ -22,9 +22,9 @@
 
 
 class ImageParam(DataSet):
-    title = StringItem(_("Title"), default=_("Image title"))
-    width = IntItem(_("Width"), default=512, help=_("Image width (pixels)"))
-    height = IntItem(_("Height"), default=512, help=_("Image height (pixels)"))
+    title = StringItem(_("Title"))
+    width = IntItem(_("Width"), help=_("Image width (pixels)"))
+    height = IntItem(_("Height"), help=_("Image height (pixels)"))
 
 
 class FilterParam(DataSet):
diff --git a/plotpy/tests/widgets/test_syncplot.py b/plotpy/tests/widgets/test_syncplot.py
@@ -75,9 +75,9 @@ def test_syncplot_curves():
 
 def test_syncplot_images():
     """Test plot synchronization: images"""
-    img1 = gen_2d_gaussian(20, np.uint8, x0=-10.0, y0=-10.0, mu=7.0, sigma=10.0)
-    img2 = gen_2d_gaussian(20, np.uint8, x0=-10.0, y0=-10.0, mu=5.0, sigma=8.0)
-    img3 = gen_2d_gaussian(20, np.uint8, x0=-10.0, y0=-10.0, mu=3.0, sigma=6.0)
+    img1 = gen_2d_gaussian(20, np.uint8, x0=-10, y0=-10, mu=7, sigma=10.0)
+    img2 = gen_2d_gaussian(20, np.uint8, x0=-10, y0=-10, mu=5, sigma=8.0)
+    img3 = gen_2d_gaussian(20, np.uint8, x0=-10, y0=-10, mu=3, sigma=6.0)
     with qt_app_context(exec_loop=True):
 
         def makeim(data):
diff --git a/plotpy/tools/curve.py b/plotpy/tools/curve.py
@@ -32,6 +32,7 @@
 from plotpy.tools.cursor import BaseCursorTool
 
 if TYPE_CHECKING:
+
     from plotpy.items.label import DataInfoLabel
     from plotpy.plot.base import BasePlot
     from plotpy.plot.manager import PlotManager
@@ -738,9 +739,9 @@ def get_coordinates(self) -> tuple[tuple[float, float], ...]:
 class InsertionDataSet(DataSet):
     """Insertion parameters"""
 
-    __index = IntItem(_("Insertion index"), min=0, default=0)
+    __index = IntItem(_("Insertion index"), min=0)
     index = __index
-    value = FloatItem(_("New value"), default=0.0)
+    value = FloatItem(_("New value"))
     index_offset = ChoiceItem(
         _("Location"), choices=[_("Before"), _("After")], default=0
     )
diff --git a/plotpy/tools/image.py b/plotpy/tools/image.py
@@ -447,11 +447,9 @@ def update_status(self, plot: BasePlot) -> None:
 class AspectRatioParam(DataSet):
     """Dataset containing aspect ratio parameters."""
 
-    lock = BoolItem(_("Lock aspect ratio"), default=True)
-    current = FloatItem(_("Current value"), default=1.0).set_prop(
-        "display", active=False
-    )
-    ratio = FloatItem(_("Lock value"), min=1e-3, default=1.0)
+    lock = BoolItem(_("Lock aspect ratio"))
+    current = FloatItem(_("Current value")).set_prop("display", active=False)
+    ratio = FloatItem(_("Lock value"), min=1e-3)
 
 
 class AspectRatioTool(CommandTool):
diff --git a/plotpy/tools/label.py b/plotpy/tools/label.py
@@ -83,7 +83,7 @@ class TextParam(DataSet):
         if textparam.edit(plot):
             text = textparam.text.replace("\n", "<br>")
 
-            label = make.label(text, (0.0, 0.0), (10, 10), "TL")
+            label = make.label(text, (0, 0), (10, 10), "TL")
             title = label.labelparam.label
             self.set_label_style(label)
             label.setTitle(self.TITLE)
diff --git a/plotpy/widgets/colormap/editor.py b/plotpy/widgets/colormap/editor.py
@@ -43,7 +43,6 @@ class ColorPickDataSet(DataSet):
             _("Relative position"),
             min=0.0,
             max=1.0,
-            default=0.5,
             help=_("Must be a value between 0.0 and 1.0."),
         )
         .set_prop("display", format="%.2f")
diff --git a/plotpy/widgets/fit.py b/plotpy/widgets/fit.py
@@ -83,8 +83,8 @@
 class AutoFitParam(DataSet):
     """Automatic fit parameters"""
 
-    xmin = FloatItem("xmin", default=0.0)
-    xmax = FloatItem("xmax", default=1.0)
+    xmin = FloatItem("xmin")
+    xmax = FloatItem("xmax")
     method = ChoiceItem(
         _("Method"),
         [
@@ -99,7 +99,7 @@ class AutoFitParam(DataSet):
     )
     err_norm = StringItem(
         "enorm",
-        default="2.0",
+        default=2.0,
         help=_("for simplex, powel, cg and bfgs norm used by the error function"),
     )
     xtol = FloatItem(
@@ -117,7 +117,7 @@ class AutoFitParam(DataSet):
 class FitParamDataSet(DataSet):
     """Fit parameter dataset"""
 
-    name = StringItem(_("Name"), default="")
+    name = StringItem(_("Name"))
     value = FloatItem(_("Value"), default=0.0)
     min = FloatItem(_("Min"), default=-1.0)
     max = FloatItem(_("Max"), default=1.0).set_pos(col=1)
@@ -612,12 +612,12 @@ def refresh(self) -> None:
         self.xrange.setVisible(self.show_xrange)
 
         if self.data_curve is None:
-            self.data_curve = make.curve([], [], _("Data"), color="b", linewidth=2.0)
+            self.data_curve = make.curve([], [], _("Data"), color="b", linewidth=2)
             plot.add_item(self.data_curve)
         self.data_curve.set_data(self.x, self.y)
 
         if self.fit_curve is None:
-            self.fit_curve = make.curve([], [], _("Fit"), color="r", linewidth=2.0)
+            self.fit_curve = make.curve([], [], _("Fit"), color="r", linewidth=2)
             plot.add_item(self.fit_curve)
         self.fit_curve.set_data(self.x, yfit)
 

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ class CurveParam(DataSet):`
`39`	`39`	`)`
`40`	`40`	`line = LineStyleItem(_("Line"))`
`41`	`41`	`symbol = SymbolItem(_("Symbol"))`
`42`		`- shade = FloatItem(_("Shadow"), default=0.0, min=0.0, max=1.0)`
	`42`	`+ shade = FloatItem(_("Shadow"), default=0, min=0, max=1)`
`43`	`43`	`curvestyle = ImageChoiceItem(_("Curve style"), CURVESTYLE_CHOICES, default="Lines")`
`44`	`44`	`baseline = FloatItem(_("Baseline"), default=0.0)`
`45`	`45`	`_use_dsamp_prop = GetAttrProp("use_dsamp")`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ class ErrorBarParam(DataSet):`
`30`	`30`	`alpha = FloatItem(`
`31`	`31`	`_("Alpha"), default=0.9, min=0, max=1, help=_("Error bar transparency")`
`32`	`32`	`)`
`33`		`- width = FloatItem(_("Width"), default=1.0, min=1.0)`
	`33`	`+ width = FloatItem(_("Width"), default=1.0, min=1)`
`34`	`34`	`cap = IntItem(_("Cap"), default=4, min=0)`
`35`	`35`	`ontop = BoolItem(_("set to foreground"), _("Visibility"), default=False)`
`36`	`36`
Original file line number	Diff line number	Diff line change
`@@ -47,9 +47,7 @@ class LabelParam(DataSet):`
`47`	`47`	`___cont = BeginGroup(_("Contents")).set_prop(`
`48`	`48`	`"display", icon="label.png", hide=GetAttrProp("_no_contents")`
`49`	`49`	`)`
`50`		`- contents = TextItem("", default="").set_prop(`
`51`		`- "display", hide=GetAttrProp("_no_contents")`
`52`		`- )`
	`50`	`+ contents = TextItem("").set_prop("display", hide=GetAttrProp("_no_contents"))`
`53`	`51`	`___econt = EndGroup(_("Contents")).set_prop(`
`54`	`52`	`"display", hide=GetAttrProp("_no_contents")`
`55`	`53`	`)`