Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix does not support nested NPM module. #1457

Open
SeungheonOh opened this issue Mar 17, 2023 · 2 comments · May be fixed by #1460
Open

Nix does not support nested NPM module. #1457

SeungheonOh opened this issue Mar 17, 2023 · 2 comments · May be fixed by #1460

Comments

@SeungheonOh
Copy link

SeungheonOh commented Mar 17, 2023 •
edited
Loading

cardano-transaction-lib/nix/default.nix

Lines 32 to 40 in acb9039

mkNodeEnv = { withDevDeps ? true }: import
(pkgs.runCommand "node-packages-${projectName}"
{
buildInputs = [ pkgs.nodePackages.node2nix ];
} ''
mkdir $out
cd $out
cp ${packageLock} ./package-lock.json
cp ${packageJson} ./package.json

When I make a submodule, nix fails because it doesn't copy the submodule.
@SeungheonOh
Copy link
Author

SeungheonOh@cd0ab69 This will fix the issue

@klntsky
Copy link
Member

klntsky commented Mar 20, 2023

@SeungheonOh please make a PR, will happily merge

@SeungheonOh SeungheonOh linked a pull request Mar 20, 2023 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Seungheonoh/npm submodule SeungheonOh/cardano-transaction-lib
2 participants
@klntsky @SeungheonOh