Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PlutusTx numeric instances for Term s PInteger #298

Closed
blamario opened this issue Feb 16, 2022 · 2 comments
Closed

Add PlutusTx numeric instances for Term s PInteger #298

blamario opened this issue Feb 16, 2022 · 2 comments

Comments

@blamario
Copy link
Collaborator

It's not the first time I get

test/Spec.hs:283:85: error:
    * No instance for (AdditiveSemigroup (Term s (PInteger @{S})))
        arising from a use of `+'

because I imported the wrong Prelude. We already have instance Num (Term s PInteger), we should add the PlutusTx.Prelude class instances as well. It literally doesn't matter which (+) is in scope, the result will be exactly the same.

@TotallyNotChase
Copy link
Collaborator

Relevant PR: #160
Relevant issue: #139

@L-as
Copy link
Member

L-as commented Jun 28, 2022

I don't think we should try to support PlutusTx more by bloating every Num etc. instance

@L-as L-as closed this as completed Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants