Bump ruff to 0.9, normalize conda recipes, clean docs to only use makefile commands

Add ruff isort to rules
apply isort
update settings

Signed-off-by: Tim Paine <[email protected]>

Author: timkpaine

Makefile

@@ -35,7 +35,6 @@ install:  ## install library
 .PHONY: lint-py lint-cpp lint lints fix-py fix-cpp fix format check checks
 
 lint-py:
-	python -m isort --check csp/ examples/ setup.py
 	python -m ruff check csp/ examples/ setup.py
 	python -m ruff format --check csp/ examples/ setup.py
 
@@ -54,7 +53,7 @@ lint: lint-py lint-docs ## run lints
 lints: lint
 
 fix-py:
-	python -m isort csp/ examples/ setup.py
+	python -m ruff check --fix csp/ examples/ setup.py
 	python -m ruff format csp/ examples/ setup.py
 
 fix-cpp:

conda/dev-environment-unix.yml

@@ -7,7 +7,7 @@ dependencies:
  - brotli
  - bump-my-version
  - cmake
- - codespell>=2.2.6,<2.3
+ - codespell>=2.4,<2.5
  - compilers
  - cyrus-sasl
  - deprecated
@@ -16,14 +16,15 @@ dependencies:
  - graphviz
  - gtest
  - httpx>=0.20,<1
- - isort>=5,<6
  - libarrow=16
  - libboost>=1.80.0
  - libboost-headers>=1.80.0
  - librdkafka
  - lz4-c
+ - make
  - mamba
- - mdformat=0.7.17
+ - mdformat>=0.7.19,<0.8
+ - mdformat-tables>=1,<1.1
  - ninja
  - numpy<2
  - pandas
@@ -44,7 +45,7 @@ dependencies:
  - rapidjson
  - requests
  - ruamel.yaml
- - ruff>=0.3,<0.4
+ - ruff>=0.9,<0.10
  - scikit-build
  - setuptools>=69,<74
  - sqlalchemy

conda/dev-environment-win.yml

@@ -3,26 +3,28 @@ channels:
   - conda-forge
   - nodefaults
 dependencies:
+#  - bison  # not available on windows
  - brotli
  - bump-my-version
  - cmake
- - codespell>=2.2.6,<2.3
+ - codespell>=2.4,<2.5
  - compilers
  - cyrus-sasl
  - deprecated
  - exprtk
+#  - flex  # not available on windows
  - graphviz
  - gtest
  - httpx>=0.20,<1
- - isort>=5,<6
  - libarrow=16
  - libboost>=1.80.0
  - libboost-headers>=1.80.0
  - librdkafka
  - lz4-c
  - make
  - mamba
- - mdformat=0.7.17
+ - mdformat>=0.7.19,<0.8
+ - mdformat-tables>=1,<1.1
  - ninja
  - numpy<2
  - pandas
@@ -43,13 +45,16 @@ dependencies:
  - rapidjson
  - requests
  - ruamel.yaml
- - ruff>=0.3,<0.4
+ - ruff>=0.9,<0.10
  - scikit-build
  - setuptools>=69,<74
  - sqlalchemy
+#  - tar  # not available on windows
  - threadpoolctl
  - tornado
  - twine
  - typing-extensions
+#  - unzip  # not available on windows
  - wheel
+#  - zip  # not available on windows
  - zlib

csp/adapters/db.py

@@ -8,8 +8,9 @@
 except ImportError:
     from backports import zoneinfo
 
-import pytz
 from importlib.metadata import PackageNotFoundError, version as get_package_version
+
+import pytz
 from packaging import version
 
 from csp import PushMode, ts

csp/adapters/output_adapters/parquet.py

@@ -1,9 +1,10 @@
-import numpy
 import os
 from importlib.metadata import PackageNotFoundError, version as get_package_version
-from packaging import version
 from typing import Callable, Dict, Optional, TypeVar
 
+import numpy
+from packaging import version
+
 import csp
 from csp.impl.struct import Struct
 from csp.impl.types.container_type_normalizer import ContainerTypeNormalizer
@@ -85,13 +86,13 @@ def __init__(
 
         if file_name and os.path.exists(file_name):
             if split_columns_to_files:
-                assert os.path.isdir(
-                    file_name
-                ), f"split_columns_to_files is True, but existing past {file_name} is file, not folder"
+                assert os.path.isdir(file_name), (
+                    f"split_columns_to_files is True, but existing past {file_name} is file, not folder"
+                )
             else:
-                assert os.path.isfile(
-                    file_name
-                ), f"split_columns_to_files is False, but existing past {file_name} is folder, not file"
+                assert os.path.isfile(file_name), (
+                    f"split_columns_to_files is False, but existing past {file_name} is folder, not file"
+                )
 
         self._all_column_names = set()
         self._properties = {

csp/adapters/output_adapters/parquet_utility_nodes.py

@@ -1,6 +1,7 @@
-import numpy
 import typing
 
+import numpy
+
 import csp
 
 T = typing.TypeVar("T")

csp/adapters/parquet.py

@@ -1,11 +1,12 @@
 import datetime
 import io
+from importlib.metadata import PackageNotFoundError, version as get_package_version
+from typing import TypeVar
+
 import numpy
 import pyarrow
 import pyarrow.parquet
-from importlib.metadata import PackageNotFoundError, version as get_package_version
 from packaging import version
-from typing import TypeVar
 
 import csp
 from csp.adapters.output_adapters.parquet import ParquetOutputConfig, ParquetWriter, resolve_array_shape_column_name

csp/adapters/perspective.py

@@ -1,8 +1,9 @@
 import threading
 from datetime import timedelta
-from perspective import Table as Table_, View as View_
 from typing import Dict, Optional, Union
 
+from perspective import Table as Table_, View as View_
+
 import csp
 from csp import ts
 from csp.impl.perspective_common import (

csp/baselib.py

@@ -2,13 +2,14 @@
 import contextlib
 import logging
 import math
-import numpy as np
-import pytz
 import queue
 import threading
 from datetime import datetime, timedelta
 from typing import Callable, Dict, List, Optional, TypeVar, Union
 
+import numpy as np
+import pytz
+
 import csp
 from csp.impl.__cspimpl import _cspimpl
 from csp.impl.constants import UNSET

csp/build/csp_autogen.py

@@ -1,7 +1,7 @@
 import argparse
 import importlib
-import importlib.util
 import importlib.machinery
+import importlib.util
 import os.path
 import sys
 import types
@@ -14,16 +14,16 @@
 csp_mod = importlib.util.module_from_spec(spec)
 sys.modules["csp"] = csp_mod
 
-from csp.impl.struct import Struct  # noqa: E402
 from csp.impl.enum import Enum  # noqa: E402
+from csp.impl.struct import Struct  # noqa: E402
 
 
 def struct_type(type_info):
-    return f"""csp::autogen::{type_info['pytype'].__name__}::Ptr"""
+    return f"""csp::autogen::{type_info["pytype"].__name__}::Ptr"""
 
 
 def enum_type(type_info):
-    return f"""csp::autogen::{type_info['pytype'].__name__}"""
+    return f"""csp::autogen::{type_info["pytype"].__name__}"""
 
 
 def array_type(type_info):
@@ -173,7 +173,7 @@ class {enum_name} : public csp::CspEnum
 
     enum_ enum_value() const {{ return ( enum_ ) value(); }}
 
-    static constexpr uint32_t num_types() {{ return {len( [ x for x in enum_type ] )}; }}
+    static constexpr uint32_t num_types() {{ return {len([x for x in enum_type])}; }}
 
     static bool static_init();