Ensure min_periods=0 is passed through rolling aggregations (rapidsai#20653)

Contributes to rapidsai#18659

Authors:
  - Matthew Murray (https://github.com/Matt711)

Approvers:
  - Tom Augspurger (https://github.com/TomAugspurger)

URL: rapidsai#20653

Author: Matt711

python/cudf/cudf/core/window/rolling.py

@@ -373,7 +373,7 @@ def _apply_agg_column(
                     source_column.plc_column,
                     pre,
                     fwd,
-                    self.min_periods or 1,
+                    1 if self.min_periods is None else self.min_periods,
                     rolling_agg,
                 )
             )
@@ -442,9 +442,7 @@ def count(self) -> DataFrame | Series:
         return self._apply_agg("count")
 
     def median(self, **kwargs):
-        raise NotImplementedError(
-            "groupby().rolling().median() is not yet implemented"
-        )
+        raise NotImplementedError("Rolling.median() is not yet implemented")
 
     def apply(self, func, *args, **kwargs) -> DataFrame | Series:
         """

python/cudf/cudf/pandas/scripts/conftest-patch.py

@@ -8034,42 +8034,10 @@ def pytest_unconfigure(config):
     "tests/window/moments/test_moments_consistency_expanding.py::test_expanding_apply_consistency_sum_nans[all_data6-2-sum]",
     "tests/window/moments/test_moments_consistency_expanding.py::test_expanding_apply_consistency_sum_nans[all_data7-0-sum]",
     "tests/window/moments/test_moments_consistency_expanding.py::test_expanding_apply_consistency_sum_nans[all_data7-2-sum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data1-rolling_consistency_cases0-False-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data1-rolling_consistency_cases0-False-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data1-rolling_consistency_cases0-True-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data1-rolling_consistency_cases0-True-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data11-rolling_consistency_cases0-False-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data11-rolling_consistency_cases0-False-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data11-rolling_consistency_cases0-True-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data11-rolling_consistency_cases0-True-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data15-rolling_consistency_cases0-False-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data15-rolling_consistency_cases0-False-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data15-rolling_consistency_cases0-True-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data15-rolling_consistency_cases0-True-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data16-rolling_consistency_cases0-False-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data16-rolling_consistency_cases0-False-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data16-rolling_consistency_cases0-True-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data16-rolling_consistency_cases0-True-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data17-rolling_consistency_cases0-False-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data17-rolling_consistency_cases0-False-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data17-rolling_consistency_cases0-True-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data17-rolling_consistency_cases0-True-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data5-rolling_consistency_cases0-False-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data5-rolling_consistency_cases0-False-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data5-rolling_consistency_cases0-True-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data5-rolling_consistency_cases0-True-nansum]",
     "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data5-rolling_consistency_cases1-False-sum]",
     "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data5-rolling_consistency_cases1-True-sum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data6-rolling_consistency_cases0-False-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data6-rolling_consistency_cases0-False-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data6-rolling_consistency_cases0-True-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data6-rolling_consistency_cases0-True-nansum]",
     "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data6-rolling_consistency_cases1-False-sum]",
     "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data6-rolling_consistency_cases1-True-sum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data7-rolling_consistency_cases0-False-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data7-rolling_consistency_cases0-False-nansum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data7-rolling_consistency_cases0-True-<lambda>]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data7-rolling_consistency_cases0-True-nansum]",
     "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data7-rolling_consistency_cases1-False-sum]",
     "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data7-rolling_consistency_cases1-True-sum]",
     "tests/window/test_api.py::test_rolling_max_min_periods[None]",
@@ -8146,7 +8114,6 @@ def pytest_unconfigure(config):
     "tests/window/test_rolling.py::test_closed_fixed_binary_col[True-10]",
     "tests/window/test_rolling.py::test_closed_fixed_binary_col[True-2]",
     "tests/window/test_rolling.py::test_closed_fixed_binary_col[True-5]",
-    "tests/window/test_rolling.py::test_missing_minp_zero",
     "tests/window/test_rolling.py::test_rolling_non_monotonic[mean-expected1]",
     "tests/window/test_rolling.py::test_rolling_non_monotonic[sum-expected2]",
     "tests/window/test_rolling.py::test_rolling_non_monotonic[var-expected0]",
@@ -8158,10 +8125,12 @@ def pytest_unconfigure(config):
     "tests/window/test_rolling.py::test_rolling_numerical_accuracy_kahan_mean[s-2.0]",
     "tests/window/test_rolling.py::test_rolling_numerical_accuracy_kahan_mean[us-0.0]",
     "tests/window/test_rolling.py::test_rolling_numerical_accuracy_kahan_mean[us-2.0]",
-    "tests/window/test_rolling.py::test_rolling_sum_all_nan_window_floating_artifacts",
     "tests/window/test_rolling.py::test_rolling_var_same_value_count_logic[values0-3-1-expected0]",
     "tests/window/test_rolling.py::test_variable_window_nonunique[DataFrame-right-expected2]",
     "tests/window/test_rolling.py::test_variable_window_nonunique[Series-right-expected2]",
+    "tests/window/test_rolling_functions.py::test_nans[mean-mean-kwargs0]",
+    "tests/window/test_rolling_functions.py::test_nans[min-min-kwargs3]",
+    "tests/window/test_rolling_functions.py::test_nans[max-max-kwargs4]",
     "tests/window/test_rolling_functions.py::test_rolling_max_gh6297[10]",
     "tests/window/test_rolling_functions.py::test_rolling_max_gh6297[1]",
     "tests/window/test_rolling_functions.py::test_rolling_max_gh6297[2]",
@@ -8195,8 +8164,8 @@ def pytest_unconfigure(config):
     "tests/window/test_timeseries_window.py::TestRollingTS::test_rolling_on_decreasing_index[s]",
     "tests/window/test_timeseries_window.py::TestRollingTS::test_rolling_on_decreasing_index[us]",
     "tests/window/test_timeseries_window.py::TestRollingTS::test_rolling_on_empty",
-    "tests/window/test_win_type.py::test_cmov_window_corner[None]",
     "tests/window/test_win_type.py::test_invalid_scipy_arg",
+    "tests/window/test_win_type.py::test_cmov_window_corner[None]",
     "tests/window/test_win_type.py::test_win_type_not_implemented",
     # dtype mismatch: cudf.pandas: pd.Index, pandas: pd.CategoricalIndex
     r"""tests/io/json/test_pandas.py::TestPandasContainer::test_json_indent_all_orients[table-{\n    "schema":{\n        "fields":[\n            {\n                "name":"index",\n                "type":"integer"\n            },\n            {\n                "name":"a",\n                "type":"string"\n            },\n            {\n                "name":"b",\n                "type":"string"\n            }\n        ],\n        "primaryKey":[\n            "index"\n        ],\n        "pandas_version":"1.4.0"\n    },\n    "data":[\n        {\n            "index":0,\n            "a":"foo",\n            "b":"bar"\n        },\n        {\n            "index":1,\n            "a":"baz",\n            "b":"qux"\n        }\n    ]\n}]""",
@@ -8552,7 +8521,51 @@ def pytest_unconfigure(config):
     "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data6-rolling_consistency_cases0-False-sum]",
     "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data6-rolling_consistency_cases0-True-sum]",
     "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data7-rolling_consistency_cases0-False-sum]",
-    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_apply_consistency_sum[all_data7-rolling_consistency_cases0-True-sum]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data1-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data1-rolling_consistency_cases0-False-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data5-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data5-rolling_consistency_cases0-False-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data6-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data6-rolling_consistency_cases0-False-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data7-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data7-rolling_consistency_cases0-False-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data11-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data11-rolling_consistency_cases0-False-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data15-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data15-rolling_consistency_cases0-False-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data16-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data16-rolling_consistency_cases0-False-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data17-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_moments_consistency_var[all_data17-rolling_consistency_cases0-False-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_series_cov_corr[series_data1-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_series_cov_corr[series_data5-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_series_cov_corr[series_data5-rolling_consistency_cases0-False-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_series_cov_corr[series_data6-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_series_cov_corr[series_data7-rolling_consistency_cases0-True-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_series_cov_corr[series_data6-rolling_consistency_cases0-False-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_series_cov_corr[series_data7-rolling_consistency_cases0-False-0]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data1-rolling_consistency_cases0-True]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data1-rolling_consistency_cases0-False]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data5-rolling_consistency_cases0-True]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data5-rolling_consistency_cases0-False]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data6-rolling_consistency_cases0-True]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data6-rolling_consistency_cases0-False]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data7-rolling_consistency_cases0-True]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data7-rolling_consistency_cases0-False]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data11-rolling_consistency_cases0-True]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data11-rolling_consistency_cases0-False]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data15-rolling_consistency_cases0-True]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data15-rolling_consistency_cases0-False]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data16-rolling_consistency_cases0-True]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data16-rolling_consistency_cases0-False]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data17-rolling_consistency_cases0-True]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_mean[all_data17-rolling_consistency_cases0-False]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_constant[consistent_data1-rolling_consistency_cases0-True]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_constant[consistent_data1-rolling_consistency_cases0-False]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_constant[consistent_data3-rolling_consistency_cases0-True]",
+    "tests/window/moments/test_moments_consistency_rolling.py::test_rolling_consistency_constant[consistent_data3-rolling_consistency_cases0-False]",
+    "tests/window/test_rolling.py::test_rolling_mean_all_nan_window_floating_artifacts[1-exp_values0]",
+    "tests/window/test_rolling.py::test_rolling_mean_all_nan_window_floating_artifacts[2-exp_values1]",
 }
 
 # TODO: Investigate why sometimes these fail

python/cudf/cudf/tests/window/test_rolling.py

@@ -536,3 +536,11 @@ def test_groupby_rolling_pickleable():
     df = cudf.DataFrame({"a": [1, 1, 2], "b": [1, 2, 3]})
     gb_rolling = pickle.loads(pickle.dumps(df.groupby("a").rolling(2)))
     assert_eq(gb_rolling.obj, cudf.DataFrame({"b": [1, 2, 3]}))
+
+
+def test_rolling_min_periods_zero():
+    s = cudf.Series([np.nan, 1.0, 2.0, 3.0])
+    ps = s.to_pandas()
+    result = s.rolling(2, min_periods=0).sum()
+    expected = ps.rolling(2, min_periods=0).sum()
+    assert_eq(result, expected)