Skip to content

Commit 04cc08a

Browse files
Improved the name of a local variable.
1 parent 009e677 commit 04cc08a

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

src/Math-Matrix/PMQRDecomposition.class.st

+11-11
Original file line numberDiff line numberDiff line change
@@ -71,18 +71,18 @@ https://en.wikipedia.org/wiki/QR_decomposition#Using_Householder_reflections
7171
{ #category : #arithmetic }
7272
PMQRDecomposition >> decomposeWithPivot [
7373

74-
| i vectorOfNormSquareds rank mx pivot matrixOfMinor |
74+
| i vectorOfNormSquareds rank positionOfMaximum pivot matrixOfMinor |
7575
vectorOfNormSquareds := matrixToDecompose columnsCollect: [
7676
:columnVector | columnVector * columnVector ].
77-
mx := vectorOfNormSquareds indexOf: vectorOfNormSquareds max.
77+
positionOfMaximum := vectorOfNormSquareds indexOf: vectorOfNormSquareds max.
7878
pivot := Array new: vectorOfNormSquareds size.
7979
rank := 0.
8080
[
8181
| householderReflection householderMatrix householderVector columnVectorFromRMatrix |
8282
rank := rank + 1.
83-
pivot at: rank put: mx.
84-
r swapColumn: rank withColumn: mx.
85-
vectorOfNormSquareds swap: rank with: mx.
83+
pivot at: rank put: positionOfMaximum.
84+
r swapColumn: rank withColumn: positionOfMaximum.
85+
vectorOfNormSquareds swap: rank with: positionOfMaximum.
8686
columnVectorFromRMatrix := r columnVectorAt: rank size: colSize.
8787
householderReflection := self
8888
householderReflectionOf:
@@ -115,16 +115,16 @@ PMQRDecomposition >> decomposeWithPivot [
115115
- (r rowAt: rank columnAt: ind) squared ].
116116
rank < vectorOfNormSquareds size
117117
ifTrue: [
118-
mx := (vectorOfNormSquareds
118+
positionOfMaximum := (vectorOfNormSquareds
119119
copyFrom: rank + 1
120120
to: vectorOfNormSquareds size) max.
121-
(mx closeTo: 0) ifTrue: [ mx := 0 ].
122-
mx := mx > 0
121+
(positionOfMaximum closeTo: 0) ifTrue: [ positionOfMaximum := 0 ].
122+
positionOfMaximum := positionOfMaximum > 0
123123
ifTrue: [
124-
vectorOfNormSquareds indexOf: mx startingAt: rank + 1 ]
124+
vectorOfNormSquareds indexOf: positionOfMaximum startingAt: rank + 1 ]
125125
ifFalse: [ 0 ] ]
126-
ifFalse: [ mx := 0 ].
127-
mx > 0 ] whileTrue.
126+
ifFalse: [ positionOfMaximum := 0 ].
127+
positionOfMaximum > 0 ] whileTrue.
128128
i := 0.
129129
[ (r rowAt: colSize) isZero ] whileTrue: [
130130
i := i + 1.

0 commit comments

Comments
 (0)