@@ -71,18 +71,18 @@ https://en.wikipedia.org/wiki/QR_decomposition#Using_Householder_reflections
71
71
{ #category : #arithmetic }
72
72
PMQRDecomposition >> decomposeWithPivot [
73
73
74
- | i vectorOfNormSquareds rank mx pivot matrixOfMinor |
74
+ | i vectorOfNormSquareds rank positionOfMaximum pivot matrixOfMinor |
75
75
vectorOfNormSquareds := matrixToDecompose columnsCollect: [
76
76
:columnVector | columnVector * columnVector ].
77
- mx := vectorOfNormSquareds indexOf: vectorOfNormSquareds max.
77
+ positionOfMaximum := vectorOfNormSquareds indexOf: vectorOfNormSquareds max.
78
78
pivot := Array new : vectorOfNormSquareds size.
79
79
rank := 0 .
80
80
[
81
81
| householderReflection householderMatrix householderVector columnVectorFromRMatrix |
82
82
rank := rank + 1 .
83
- pivot at: rank put: mx .
84
- r swapColumn: rank withColumn: mx .
85
- vectorOfNormSquareds swap: rank with: mx .
83
+ pivot at: rank put: positionOfMaximum .
84
+ r swapColumn: rank withColumn: positionOfMaximum .
85
+ vectorOfNormSquareds swap: rank with: positionOfMaximum .
86
86
columnVectorFromRMatrix := r columnVectorAt: rank size: colSize.
87
87
householderReflection := self
88
88
householderReflectionOf:
@@ -115,16 +115,16 @@ PMQRDecomposition >> decomposeWithPivot [
115
115
- (r rowAt: rank columnAt: ind) squared ].
116
116
rank < vectorOfNormSquareds size
117
117
ifTrue: [
118
- mx := (vectorOfNormSquareds
118
+ positionOfMaximum := (vectorOfNormSquareds
119
119
copyFrom: rank + 1
120
120
to: vectorOfNormSquareds size) max.
121
- (mx closeTo: 0 ) ifTrue: [ mx := 0 ].
122
- mx := mx > 0
121
+ (positionOfMaximum closeTo: 0 ) ifTrue: [ positionOfMaximum := 0 ].
122
+ positionOfMaximum := positionOfMaximum > 0
123
123
ifTrue: [
124
- vectorOfNormSquareds indexOf: mx startingAt: rank + 1 ]
124
+ vectorOfNormSquareds indexOf: positionOfMaximum startingAt: rank + 1 ]
125
125
ifFalse: [ 0 ] ]
126
- ifFalse: [ mx := 0 ].
127
- mx > 0 ] whileTrue.
126
+ ifFalse: [ positionOfMaximum := 0 ].
127
+ positionOfMaximum > 0 ] whileTrue.
128
128
i := 0 .
129
129
[ (r rowAt: colSize) isZero ] whileTrue: [
130
130
i := i + 1 .
0 commit comments