Skip to content

Commit 5882cd2

Browse files
authored
Merge pull request #583 from PolymerElements/no-invalid-typedef
This code was using @typedef like @type, which is invalid
2 parents 275c510 + 4e38e15 commit 5882cd2

5 files changed

Lines changed: 5 additions & 24 deletions

File tree

app-scroll-effects/effects/blend-background.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,7 @@ registerEffect('blend-background', {
4848
class BlendBackground {
4949
constructor() {
5050
/**
51-
* @typedef {{
52-
* backgroundFrontLayer: !HTMLElement,
53-
* backgroundRearLayer: !HTMLElement,
54-
* }}
51+
* @type {?}
5552
*/
5653
this._fxBlendBackground;
5754
}

app-scroll-effects/effects/fade-background.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,7 @@ registerEffect('fade-background', {
5757
class FadeBackground {
5858
constructor() {
5959
/**
60-
* @typedef {{
61-
* backgroundFrontLayer: !HTMLElement,
62-
* backgroundRearLayer: !HTMLElement,
63-
* }}
60+
* @type {?}
6461
*/
6562
this._fxFadeBackground;
6663
}

app-scroll-effects/effects/parallax-background.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -69,11 +69,7 @@ class ParallaxBackground {
6969
this._dHeight;
7070

7171
/**
72-
* @typedef {{
73-
* background: !HTMLElement,
74-
* backgroundFrontLayer: !HTMLElement,
75-
* backgroundRearLayer: !HTMLElement,
76-
* }}
72+
* @type {?}
7773
*/
7874
this._fxParallaxBackground;
7975
}

app-scroll-effects/effects/resize-snapped-title.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,7 @@ registerEffect('resize-snapped-title', {
7070
class ResizeSnappedTitle {
7171
constructor() {
7272
/**
73-
* @typedef {{
74-
* title: !HTMLElement,
75-
* condensedTitle: !HTMLElement,
76-
* }}
73+
* @type {?}
7774
*/
7875
this._fxResizeSnappedTitle;
7976
}

app-scroll-effects/effects/resize-title.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,7 @@ class ResizeTitle {
103103
this.condenses;
104104

105105
/**
106-
* @typedef {{
107-
* title: !HTMLElement,
108-
* condensedTitle: !HTMLElement,
109-
* scale: number,
110-
* titleDX: number,
111-
* titleDY: number,
112-
* }}
106+
* @@type {?}
113107
*/
114108
this._fxResizeTitle;
115109
}

0 commit comments

Comments
 (0)