Retain branch color for open branches (#143)

* Retain branch color for open branches

Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>

* cleanup

Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>

* Fix order in stylesheet to make it more robust

Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>

---------

Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com>

Author: Thijss

src/power_grid_model_ds/_core/visualizer/layout/cytoscape_styling.py

@@ -115,7 +115,6 @@
     "selector": "edge[from_status = 0], edge[to_status = 0]",
     "style": {
         "line-style": "dashed",
-        "line-color": CYTO_COLORS["open_branch"],
         "target-arrow-color": CYTO_COLORS["open_branch"],
         "source-arrow-color": CYTO_COLORS["open_branch"],
     },
@@ -147,11 +146,12 @@
     _SELECTED_BRANCH_STYLE,
     _SELECTED_TRANSFORMER_STYLE,
     _SELECTED_LINK_STYLE,
-    _OPEN_BRANCH_STYLE,
-    _OPEN_FROM_SIDE_BRANCH_STYLE,
-    _OPEN_TO_SIDE_BRANCH_STYLE,
     _GENERIC_BRANCH_STYLE,
     _SELECTED_GENERIC_BRANCH_STYLE,
     _ASYM_LINE_STYLE,
     _SELECTED_ASYM_LINE_STYLE,
+    # Note: Keep the OPEN BRANCH styles last in list, otherwise they potentially get overridden.
+    _OPEN_BRANCH_STYLE,
+    _OPEN_FROM_SIDE_BRANCH_STYLE,
+    _OPEN_TO_SIDE_BRANCH_STYLE,
 ]

tests/integration/visualizer_tests.py

@@ -22,7 +22,7 @@ def get_radial_grid() -> Grid:
 
 def get_coordinated_grid() -> CoordinatedGrid:
     scale = 500
-    grid = CoordinatedGrid.from_txt("S1 2 open", "2 3", "3 4", "S1 500000000", "500000000 6", "6 7 transformer")
+    grid = CoordinatedGrid.from_txt("S1 2 open", "2 3", "3 4", "S1 500000000", "500000000 6", "6 7 transformer,open")
     grid.node.x = [3, 2.5, 2, 1.5, 3.5, 4, 4.5]
     grid.node.x *= scale
     grid.node.y = [3, 4, 3, 4, 3, 4, 3]
@@ -61,8 +61,20 @@ def visualize_grid_with_all_types():
     visualize(grid=grid, debug=True)
 
 
+def visualize_grid_with_all_open_types():
+    grid = Grid.from_txt(
+        "1 2 12,open",
+        "2 3 link,23,open",
+        "3 4 transformer,34,open",
+        "4 5 generic_branch,45,open",
+        "5 6 asym_line,56,open",
+    )
+    visualize(grid=grid, debug=True)
+
+
 if __name__ == "__main__":
     # visualize_grid()
     # visualize_coordinated_grid()
     # visualize_grid_with_links()
-    visualize_grid_with_all_types()
+    # visualize_grid_with_all_types()
+    visualize_grid_with_all_open_types()