Skip to content

Commit b9e4d04

Browse files
authored
Remove Fuzzy Gdown Argument (#784)
### Description This removes the now deprecated gdown "fuzzy" argument. This has found to be a breaking issue for running the CI for new bundles. ### Status **Ready** ### Please ensure all the checkboxes: <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Codeformat tests passed locally by running `./runtests.sh --codeformat`. - [ ] In-line docstrings updated. - [ ] Update `version` and `changelog` in `metadata.json` if changing an existing bundle. - [ ] Please ensure the naming rules in config files meet our requirements (please refer to: `CONTRIBUTING.md`). - [ ] Ensure versions of packages such as `monai`, `pytorch` and `numpy` are correct in `metadata.json`. - [ ] Descriptions should be consistent with the content, such as `eval_metrics` of the provided weights and TorchScript modules. - [ ] Files larger than 25MB are excluded and replaced by providing download links in `large_file.yml`. - [ ] Avoid using path that contains personal information within config files (such as use `/home/your_name/` for `"bundle_root"`). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Adjusted large-file download handling to use the provided file details as-is, improving consistency when fetching files. * Streamlined download processing with no visible change to the user experience. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
1 parent d382e59 commit b9e4d04

3 files changed

Lines changed: 0 additions & 3 deletions

File tree

ci/utils.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ def download_large_files(bundle_path: str, large_file_name: str = "large_file.ym
129129
parser.read_config(os.path.join(bundle_path, large_file_name))
130130
large_files_list = parser.get()["large_files"]
131131
for lf_data in large_files_list:
132-
lf_data["fuzzy"] = True
133132
if "hash_val" in lf_data and lf_data.get("hash_val", "") == "":
134133
lf_data.pop("hash_val")
135134
if "hash_type" in lf_data and lf_data.get("hash_type", "") == "":

ci/utils_deparate.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@ def download_large_files(bundle_path: str, large_file_name: str = "large_file.ym
9595
parser.read_config(os.path.join(bundle_path, large_file_name))
9696
large_files_list = parser.get()["large_files"]
9797
for lf_data in large_files_list:
98-
lf_data["fuzzy"] = True
9998
if "hash_val" in lf_data and lf_data.get("hash_val", "") == "":
10099
lf_data.pop("hash_val")
101100
if "hash_type" in lf_data and lf_data.get("hash_type", "") == "":

ci/utils_deparate_ngc.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ def download_large_files(bundle_path: str, large_file_name: str = "large_file.ym
9898
parser.read_config(os.path.join(bundle_path, large_file_name))
9999
large_files_list = parser.get()["large_files"]
100100
for lf_data in large_files_list:
101-
lf_data["fuzzy"] = True
102101
if "hash_val" in lf_data and lf_data.get("hash_val", "") == "":
103102
lf_data.pop("hash_val")
104103
if "hash_type" in lf_data and lf_data.get("hash_type", "") == "":

0 commit comments

Comments
 (0)