Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt a bundle friendly and ESM compatible fork of escodegen #140

Closed
thescientist13 opened this issue Feb 10, 2024 · 0 comments · Fixed by #141 or #149
Closed

adopt a bundle friendly and ESM compatible fork of escodegen #140

thescientist13 opened this issue Feb 10, 2024 · 0 comments · Fixed by #141 or #149
Assignees
Labels
0.12.0 feature New feature or request
Milestone

Comments

@thescientist13
Copy link
Member

Summary

As reported upstream in estools/escodegen#455, there is a key issue in that in order to use escodegen, you need to have a process that understands how to handle a require of JSON, as can be seen in WCC's custom rollup configuration for bundling a CJS version of WCC

exports.version = require('./package.json').version;

Details

So for anyone using WCC, like Greenwood, its required to add a JSON plugin, in our case for Rollup.

Also while we're here, might as well refactor for ESM.

@thescientist13 thescientist13 added the feature New feature or request label Feb 10, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Feb 10, 2024
@thescientist13 thescientist13 self-assigned this Feb 10, 2024
@thescientist13 thescientist13 changed the title vendor a bundle friendly and ESM compatible fork of escodegen adopt a bundle friendly and ESM compatible fork of escodegen Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.12.0 feature New feature or request
Projects
No open projects
1 participant