Skip to content

Commit 45f1ca6

Browse files
Fix checkdoc warnings
Went from 779 checkdoc warnings to 29
1 parent a0a71cb commit 45f1ca6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+960
-813
lines changed

ci/compile-tests/001-mini-project/runtest.el

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
;; This file is part of Proof General. -*- lexical-binding: t; -*-
1+
;;; runtest.el --- Test -*- lexical-binding: t; -*-
2+
;;
3+
;; This file is part of Proof General.
24
;;
35
;; © Copyright 2020 Hendrik Tews
46
;;
@@ -24,6 +26,7 @@
2426
;; / \ / \
2527
;; d e f
2628

29+
;;; Code:
2730

2831
;; require cct-lib for the elisp compilation, otherwise this is present already
2932
(require 'cct-lib "ci/compile-tests/cct-lib")
@@ -42,3 +45,7 @@
4245
(cct-check-locked 24 'locked)
4346
(cct-locked-ancestors 22 '("./b.v" "./d.v" "./e.v"))
4447
(cct-locked-ancestors 23 '("./c.v" "./f.v")))
48+
49+
(provide 'runtest)
50+
51+
;;; runtest.el ends here

ci/compile-tests/002-require-no-dependencies/runtest.el

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
;; This file is part of Proof General. -*- lexical-binding: t; -*-
1+
;;; runtest.el --- Test -*- lexical-binding: t; -*-
2+
;;
3+
;; This file is part of Proof General.
24
;;
35
;; © Copyright 2020 Hendrik Tews
46
;;
@@ -21,6 +23,7 @@
2123
;; |
2224
;; c
2325

26+
;;; Code:
2427

2528
;; require cct-lib for the elisp compilation, otherwise this is present already
2629
(require 'cct-lib "ci/compile-tests/cct-lib")
@@ -46,3 +49,7 @@
4649
(cct-check-locked 24 'locked)
4750
(cct-locked-ancestors 22 '())
4851
(cct-locked-ancestors 23 '("./c.v")))
52+
53+
(provide 'runtest)
54+
55+
;;; runtest.el ends here

ci/compile-tests/003-require-error/runtest.el

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
;; This file is part of Proof General. -*- lexical-binding: t; -*-
1+
;;; runtest.el --- Test -*- lexical-binding: t; -*-
2+
;;
3+
;; This file is part of Proof General.
24
;;
35
;; © Copyright 2020 Hendrik Tews
46
;;
@@ -24,6 +26,7 @@
2426
;;
2527
;; and where a1, a2 and a3 are the 3 require commands in file a.v
2628

29+
;;; Code:
2730

2831
;; require cct-lib for the elisp compilation, otherwise this is present already
2932
(require 'cct-lib "ci/compile-tests/cct-lib")
@@ -43,3 +46,7 @@
4346
(cct-check-locked 23 'unlocked)
4447
(cct-file-newer "b.vo" test-start-time)
4548
(cct-file-newer "c.vo" test-start-time)))
49+
50+
(provide 'runtest)
51+
52+
;;; runtest.el ends here

ci/compile-tests/004-dependency-cycle/runtest.el

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
;; This file is part of Proof General. -*- lexical-binding: t; -*-
1+
;;; runtest.el --- Test -*- lexical-binding: t; -*-
2+
;;
3+
;; This file is part of Proof General.
24
;;
35
;; © Copyright 2020 Hendrik Tews
46
;;
@@ -24,6 +26,7 @@
2426
;;
2527
;; where a1 and a2 are the 2 require commands in file a.v.
2628

29+
;;; Code:
2730

2831
;; require cct-lib for the elisp compilation, otherwise this is present already
2932
(require 'cct-lib "ci/compile-tests/cct-lib")
@@ -59,3 +62,7 @@
5962

6063
(cct-check-locked 21 'locked)
6164
(cct-check-locked 22 'unlocked)))
65+
66+
(provide 'runtest)
67+
68+
;;; runtest.el ends here

ci/compile-tests/005-change-recompile/runtest.el

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
;; This file is part of Proof General. -*- lexical-binding: t; -*-
1+
;;; runtest.el --- Test -*- lexical-binding: t; -*-
2+
;;
3+
;; This file is part of Proof General.
24
;;
35
;; © Copyright 2020 Hendrik Tews
46
;;
@@ -35,6 +37,8 @@
3537
;;
3638
;;
3739

40+
;;; Code:
41+
3842
;; require cct-lib for the elisp compilation, otherwise this is present already
3943
(require 'cct-lib "ci/compile-tests/cct-lib")
4044

@@ -197,3 +201,7 @@ See `cct-generic-check-main-buffer'."
197201
(check-main-buffer vo-times "71" '("./b.vo" "./d.vo" "./g.vo")
198202
other-locked-files)
199203
))
204+
205+
(provide 'runtest)
206+
207+
;;; runtest.el ends here

ci/compile-tests/006-ready-dependee/runtest.el

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
;; This file is part of Proof General. -*- lexical-binding: t; -*-
1+
;;; runtest.el --- Test -*- lexical-binding: t; -*-
2+
;;
3+
;; This file is part of Proof General.
24
;;
35
;; © Copyright 2020 Hendrik Tews
46
;;
@@ -27,12 +29,13 @@
2729
;;
2830
;; The idea is that the coqdep chain from b to j takes so long, that k
2931
;; has been compiled and is in state ready before the coqdep results
30-
;; from j are processed. This works - unless the disk cache is cold.
31-
;; If it works the test triggers two bugs. First, k is locked with the
32+
;; from j are processed. This works - unless the disk cache is cold.
33+
;; If it works the test triggers two bugs. First, k is locked with the
3234
;; require command of c. Second, the modification time of k is not
3335
;; propagated to j, such that the whole chain from j to b is not
3436
;; recompiled after k has changed.
3537

38+
;;; Code:
3639

3740
;; require cct-lib for the elisp compilation, otherwise this is present already
3841
(require 'cct-lib "ci/compile-tests/cct-lib")
@@ -59,7 +62,7 @@
5962
(defun cct-replace-last-word (line word)
6063
"Replace last word in line LINE with WORD.
6164
In current buffer, go to the end of line LINE and one word
62-
backward. Replace the word there with WORD."
65+
backward. Replace the word there with WORD."
6366
(cct-goto-line line)
6467
(end-of-line)
6568
(backward-word)
@@ -130,3 +133,7 @@ Combine all the following tests in this order:
130133
"./h.vo" "./i.vo" "./j.vo" "./k.vo")
131134
other-locked-files)
132135
))
136+
137+
(provide 'runtest)
138+
139+
;;; runtest.el ends here

ci/compile-tests/007-slow-require/runtest.el

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
;; This file is part of Proof General. -*- lexical-binding: t; -*-
1+
;;; runtest.el --- Test -*- lexical-binding: t; -*-
2+
;;
3+
;; This file is part of Proof General.
24
;;
35
;; © Copyright 2021 Hendrik Tews
46
;;
@@ -14,11 +16,11 @@
1416
;;
1517
;; Test two require jobs with different delays such that
1618
;; coq-par-retire-top-level-job happens when the other require job is
17-
;; in each possible state. For specifying the different delays there
18-
;; are 6 mini projects, one for each test in this file. Each project
19+
;; in each possible state. For specifying the different delays there
20+
;; are 6 mini projects, one for each test in this file. Each project
1921
;; consists of four files, a1.v, b1.v, c1.v and d1.v for the first one
20-
;; and a6.v, b6.v, c6.v and d6.v for the sixth one. Each project is
21-
;; one ert test, described further below. In each project or test, the
22+
;; and a6.v, b6.v, c6.v and d6.v for the sixth one. Each project is
23+
;; one ert test, described further below. In each project or test, the
2224
;; top level require commands are asserted and retracted several times
2325
;; with changes in different files to test (almost) all possible
2426
;; internal state combinations.
@@ -53,12 +55,14 @@
5355
;; seconds, such that the dependency link d->c is created when d is in
5456
;; state enqueued-coqc.
5557

58+
;;; Code:
59+
5660
;; require cct-lib for the elisp compilation, otherwise this is present already
5761
(require 'cct-lib "ci/compile-tests/cct-lib")
5862

5963
;;; set configuration
6064
(cct-configure-proof-general)
61-
(configure-delayed-coq)
65+
(configure-delayed-coq)
6266

6367
(defconst pre-b-ancestors '("./b" "./d")
6468
"Ancestors of b without suffixes.")
@@ -213,3 +217,7 @@ XXX Test a setting where the second require job is still in state
213217
(ert-deftest cct-slow-require-4 () (test-slow-require 4))
214218
(ert-deftest cct-slow-require-5 () (test-slow-require 5))
215219
(ert-deftest cct-slow-require-6 () (test-slow-require 6))
220+
221+
(provide 'runtest)
222+
223+
;;; runtest.el ends here

ci/compile-tests/008-default-dir/runtest.el

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
;; This file is part of Proof General. -*- lexical-binding: t; -*-
1+
;;; runtest.el --- Test -*- lexical-binding: t; -*-
2+
;;
3+
;; This file is part of Proof General.
24
;;
35
;; © Copyright 2021 Hendrik Tews
46
;;
@@ -29,13 +31,14 @@
2931
;; c
3032
;;
3133

34+
;;; Code:
3235

3336
;; require cct-lib for the elisp compilation, otherwise this is present already
3437
(require 'cct-lib "ci/compile-tests/cct-lib")
3538

3639
;;; set configuration
3740
(cct-configure-proof-general)
38-
(configure-delayed-coq)
41+
(configure-delayed-coq)
3942

4043
(defconst all-ancestors '("./b.v" "./c.v")
4144
"All ancestors.")
@@ -151,3 +154,7 @@ situations. See Coq issue 15773."
151154
(cct-unmodified-change-times vo-times))
152155
(cct-older-change-times vo-times))
153156
))
157+
158+
(provide 'runtest)
159+
160+
;;; runtest.el ends here

ci/compile-tests/009-failure-processing/runtest.el

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
;; This file is part of Proof General. -*- lexical-binding: t; -*-
1+
;;; runtest.el --- Test -*- lexical-binding: t; -*-
2+
;;
3+
;; This file is part of Proof General.
24
;;
35
;; © Copyright 2021 Hendrik Tews
46
;;
@@ -13,8 +15,8 @@
1315
;; ert tests for parallel background compilation for Coq
1416
;;
1517
;; Test a partially successful and partially failing compilation with
16-
;; coq-compile-keep-going. Check that the right files are compiled,
17-
;; locked and unlocked. Check also the case, where unlocking of failed
18+
;; coq-compile-keep-going. Check that the right files are compiled,
19+
;; locked and unlocked. Check also the case, where unlocking of failed
1820
;; files must be delayed, because some earlier successful require job
1921
;; has not yet locked its ancestors.
2022
;;
@@ -36,8 +38,8 @@
3638
;;
3739
;; Rb, Rc and Rd are three different require commands in file a. The
3840
;; dependency e -> b is not present in test 5 and test 10 (but in all
39-
;; other tests). The error always happens in file g, for test 1-5 with
40-
;; coqdep, for tests 6-10 with coqc. There are 10 tests, each with
41+
;; other tests). The error always happens in file g, for test 1-5 with
42+
;; coqdep, for tests 6-10 with coqc. There are 10 tests, each with
4143
;; slighly different delays, in 10 versions of the sources, e.g.,
4244
;; a1-a10, b1-b10, and so on.
4345
;;
@@ -58,14 +60,14 @@
5860
;; 9: RB is ready and Rd is queue waiting
5961
;; 10: without dependency b -> e: Rc, Rd are queue waiting, b finishes last
6062

61-
63+
;;; Code:
6264

6365
;; require cct-lib for the elisp compilation, otherwise this is present already
6466
(require 'cct-lib "ci/compile-tests/cct-lib")
6567

6668
;;; set configuration
6769
(cct-configure-proof-general)
68-
(configure-delayed-coq)
70+
(configure-delayed-coq)
6971

7072
(defconst pre-b-ancestors '("b" "f")
7173
"Ancestors of b without suffixes.")
@@ -76,8 +78,8 @@
7678
(defun pre-not-compiled (n)
7779
"List of file name stems for which coqc must not be called.
7880
Files for which coqc must not be called have an ``X'' in
79-
coqc-delay. For such files `compile-test-start-delayed' would
80-
create a ``.X'' file, whose absense is checked in the test."
81+
coqc-delay. For such files `compile-test-start-delayed' would
82+
create a ``.X'' file, whose absence is checked in the test."
8183
(cond
8284
((< n 6) '("g" "c"))
8385
(t '("c"))))
@@ -140,3 +142,7 @@ create a ``.X'' file, whose absense is checked in the test."
140142
(ert-deftest cct-failure-processing-08 () (test-failure-processing 8))
141143
(ert-deftest cct-failure-processing-09 () (test-failure-processing 9))
142144
(ert-deftest cct-failure-processing-10 () (test-failure-processing 10))
145+
146+
(provide 'runtest)
147+
148+
;;; runtest.el ends here

ci/compile-tests/010-coqdep-errors/runtest.el

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
;; This file is part of Proof General. -*- lexical-binding: t; -*-
1+
;;; runtest.el --- Test -*- lexical-binding: t; -*-
2+
;;
3+
;; This file is part of Proof General.
24
;;
35
;; © Copyright 2024 Hendrik Tews
46
;;
@@ -13,7 +15,7 @@
1315
;; ert tests for parallel background compilation for Coq
1416
;;
1517
;; Test that parallel background compilation reliably detects coqdep
16-
;; errors. There are three tests that check the following coqdep errors:
18+
;; errors. There are three tests that check the following coqdep errors:
1719
;; - coqdep on a require fails because of a missing library (using a.v)
1820
;; - coqdep on a dependency fails because of a syntax error (using b.v)
1921
;; - coqdep on a dependency fails because of a missing library (using d.v)
@@ -24,6 +26,7 @@
2426
;; | |
2527
;; c e
2628

29+
;;; Code:
2730

2831
;; require cct-lib for the elisp compilation, otherwise this is present already
2932
(require 'cct-lib "ci/compile-tests/cct-lib")
@@ -126,3 +129,7 @@
126129
(should (and coqdep-errror-in-response
127130
missing-module-in-response
128131
(not dependency-in-coq)))))
132+
133+
(provide 'runtest)
134+
135+
;;; runtest.el ends here

0 commit comments

Comments
 (0)