PHPCS 4.0 compat

Author: BafS

Proton/Sniffs/Spacing/ArrowFunctionSpacingSniff.php

@@ -24,9 +24,9 @@ public function process(File $phpcsFile, $stackPtr): void
     {
         $tokens = $phpcsFile->getTokens();
 
-        if ($tokens[$stackPtr]['code'] === T_FN && $tokens[$stackPtr + 1]['code'] !== T_WHITESPACE) {
+        if ($tokens[$stackPtr]['code'] === T_FN && $tokens[$stackPtr + 1]['code'] !== T_OPEN_PARENTHESIS) {
             $phpcsFile->addError(
-                'The fn arrow function token should always be followed by a space.',
+                'The fn arrow function token should never be followed by a space.',
                 $stackPtr,
                 'Found',
             );

Proton/ruleset.xml

@@ -1,5 +1,9 @@
 <?xml version="1.0"?>
-<ruleset name="Proton">
+<ruleset
+        name="Proton"
+        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="../../vendor/squizlabs/php_codesniffer/phpcs.xsd"
+>
     <description>
         Proton PHP Coding Standard
     </description>
@@ -123,7 +127,6 @@
 
     <!-- # Slevomat Coding Standard -->
     <!-- https://github.com/slevomat/coding-standard -->
-    <config name="installed_paths" value="../../slevomat/coding-standard"/>
 
     <rule ref="SlevomatCodingStandard.PHP.TypeCast"/>
     <rule ref="SlevomatCodingStandard.PHP.ShortList"/>
@@ -133,6 +136,7 @@
             <property name="ignoreComplexTernaryConditions" value="1"/>
         </properties>
     </rule>
+    <rule ref="SlevomatCodingStandard.PHP.UselessParentheses"/>
     <!-- Require usage of constructor property promotion -->
     <rule ref="SlevomatCodingStandard.Classes.RequireConstructorPropertyPromotion"/>
     <!-- Forbid uses of multiple traits separated by comma -->

composer.json

@@ -17,8 +17,8 @@
     },
     "require": {
         "php": "^8.0",
-        "slevomat/coding-standard": "^8.0",
-        "squizlabs/php_codesniffer": "^3.7"
+        "slevomat/coding-standard": "^8.22",
+        "squizlabs/php_codesniffer": "^4.0"
     },
     "license": "MIT",
     "config": {

phpcs.xml

@@ -4,7 +4,7 @@
         Proton PHP Coding Standard
     </description>
 
-    <config name="installed_paths" value="Proton"/>
+    <arg name="basepath" value="." />
 
     <rule ref="Proton"/>
 

tests/correct/ClassOk.php

@@ -37,7 +37,7 @@ public function __construct(array $config)
 
         phpinfo2();
 
-        call_user_func(fn () => {});
+        call_user_func(fn() => {});
     }
 
     public function ping(Request $request): mixed

tests/expected_csv.txt

@@ -1,9 +1,9 @@
 Line,Column,Type,Source
+7,1,error,Generic.NamingConventions.TraitNameSuffix.Missing
+7,1,error,Generic.NamingConventions.InterfaceNameSuffix.Missing
 4,10,error,PSR2.Files.EndFileNewline.NoneFound
 3,1,error,SlevomatCodingStandard.Commenting.EmptyComment.EmptyComment
 1,1,error,SlevomatCodingStandard.TypeHints.DeclareStrictTypes.DeclareStrictTypesMissing
-7,1,error,Generic.NamingConventions.TraitNameSuffix.Missing
-7,1,error,Generic.NamingConventions.InterfaceNameSuffix.Missing
 6,9,error,Generic.Arrays.ArrayIndent.KeyIncorrect
 21,1,error,Generic.Files.InlineHTML.Found
 17,17,error, use === instead."
@@ -16,6 +16,7 @@ Line,Column,Type,Source
 53,9,error,SlevomatCodingStandard.Commenting.EmptyComment.EmptyComment
 52,9,error,Proton.Commenting.InlineCommentStartsWithSpace.WrongStyle
 51,9,error,SlevomatCodingStandard.Commenting.EmptyComment.EmptyComment
+49,9,error,Proton.Commenting.InlineCommentStartsWithSpace.WrongStyle
 49,9,error,SlevomatCodingStandard.Commenting.EmptyComment.EmptyComment
 48,9,error,SlevomatCodingStandard.Commenting.EmptyComment.EmptyComment
 47,9,error,PEAR.Commenting.InlineComment.WrongStyle
@@ -24,6 +25,7 @@ Line,Column,Type,Source
 44,9,error,Proton.Commenting.InlineCommentStartsWithSpace.WrongStyle
 40,37,error,SlevomatCodingStandard.Attributes.RequireAttributeAfterDocComment.AttributeBeforeDocComment
 34,5,error,SlevomatCodingStandard.Attributes.RequireAttributeAfterDocComment.AttributeBeforeDocComment
+3,24,error,PSR12.Files.FileHeader.SpacingAfterDeclareBlock
 3,1,error, found 2."
 29,9,error,Proton.Commenting.InlineCommentStartsWithSpace.WrongStyle
 24,8,error,SlevomatCodingStandard.Commenting.ForbiddenComments.CommentForbidden
@@ -57,7 +59,7 @@ Line,Column,Type,Source
 64,27,error,Squiz.PHP.DisallowMultipleAssignments.FoundInControlStructure
 64,16,error, use === instead."
 63,62,error,Squiz.Functions.MultiLineFunctionDeclaration.BraceOnSameLine
-6,18,error,PSR12.Files.FileHeader.SpacingInsideBlock
+6,18,error,PSR12.Files.FileHeader.SpacingInsideUseBlock
 6,1,error,SlevomatCodingStandard.Namespaces.UnusedUses.UnusedUse
 58,60,error,SlevomatCodingStandard.TypeHints.DNFTypeHintFormat.NullTypeHintNotOnLastPosition
 58,32,error,SlevomatCodingStandard.TypeHints.DNFTypeHintFormat.NullTypeHintNotOnLastPosition
@@ -102,10 +104,12 @@ Line,Column,Type,Source
 16,16,error,PSR12.Traits.UseDeclaration.MultipleImport
 14,5,warning,PSR12.Properties.ConstantVisibility.NotFound
 12,13,error,SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingAnyTypeHint
+12,13,error,SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingAnyTypeHint
 12,13,error,Squiz.NamingConventions.ValidVariableName.MemberNotCamelCaps
 12,1,error,Generic.WhiteSpace.DisallowTabIndent.TabsUsed
 10,27,error,SlevomatCodingStandard.Classes.EmptyLinesAroundClassBraces.IncorrectEmptyLinesAfterOpeningBrace
 10,27,error,PSR2.Classes.ClassDeclaration.OpenBraceNewLine
 10,27,error,PSR12.Classes.OpeningBraceSpace.Found
 10,16,error,Generic.NamingConventions.AbstractClassNamePrefix.Missing
 1,1,error,SlevomatCodingStandard.TypeHints.DeclareStrictTypes.DeclareStrictTypesMissing
+1,1,error,PSR12.Files.FileHeader.SpacingAfterTagBlock

tests/wrong/Class1.php

@@ -28,7 +28,7 @@ public function __construct()
         $this->test = new class() {
         };
 
-        call_user_func(fn() => {});
+        call_user_func(fn () => {});
     }
 
     private function unused() {