refactor(ipc): replace Malt+BSON with binary protocol #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Custom binary serialization for typed request/response structs - Direct socket communication instead of Malt RPC - Add protocol roundtrip tests - Update tests for RenderResponse struct access
Replace @lock macro (Julia 1.7+) with lock() do for 1.6 support. Treat unknown msg_id as protocol corruption and break receive loop instead of continuing, which would leave caller blocked forever.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
+ Coverage 76.20% 78.25% +2.04%
==========================================
Files 48 47 -1
Lines 2135 2304 +169
==========================================
+ Hits 1627 1803 +176
+ Misses 508 501 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use parametric PendingCall{R} with typed channels instead of
Channel{Any}. deliver!() dispatches on response type for type stability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that serialisation with BSON.jl was generating a large amount of allocations. This switches it out for a much simpler, less generic, custom format that that reduces allocations in the boundary between runner and workers significantly. Also removes all uses of
evalin the transport layer, which was a hold-over fromMaltusage, but isn't strictly needed for our simpler needs here. Finally, theMaltimplementation itself has been replaced a simpler implementation since we needed need all those features listed above. Things like the "message boundary marker" has been replaced with a length-encoded protocol to ensure we don't encounter that magic boundary marker in real data. Some potential race conditions have also been fixed up in both the worker and runner logic.