Skip to content

Commit 7d8db11

Browse files
committed
Further cleanup using async/await
1 parent 88fea9a commit 7d8db11

File tree

3 files changed

+7
-27
lines changed

3 files changed

+7
-27
lines changed

.eslintrc.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,6 @@ module.exports = {
1212
rules: {},
1313
globals: {
1414
eBookConfig: "readonly",
15+
require: "readonly",
1516
},
1617
};

runestone/activecode/js/activecode_html.js

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export default class HTMLActiveCode extends ActiveCode {
1212
async runProg() {
1313
var prog = await this.buildProg(true);
1414
let saveCode = "True";
15-
saveCode = await this.manage_scrubber(saveCode);
15+
this.saveCode = await this.manage_scrubber(saveCode);
1616
$(this.output).text("");
1717
if (!this.alignVertical) {
1818
$(this.codeDiv).switchClass("col-md-12", "col-md-6", {
@@ -25,17 +25,8 @@ export default class HTMLActiveCode extends ActiveCode {
2525
"<script type=text/javascript>window.onerror = function(msg,url,line) {alert(msg+' on line: '+line);};</script>" +
2626
prog;
2727
this.output.srcdoc = prog;
28-
this.logRunEvent({
29-
div_id: this.divid,
30-
code: this.editor.getValue(),
31-
errinfo: "success",
32-
to_save: saveCode,
33-
prefix: this.pretext,
34-
suffix: this.suffix,
35-
lang: this.language,
36-
partner: this.partner,
37-
}); // Log the run event
3828
}
29+
3930
createOutput() {
4031
this.alignVertical = true;
4132
var outDiv = document.createElement("div");

runestone/activecode/js/activecode_js.js

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ export default class JSActiveCode extends ActiveCode {
3131
}
3232
async runProg() {
3333
var _this = this;
34-
var prog = this.buildProg(true);
35-
var einfo;
34+
var prog = await this.buildProg(true);
3635
var saveCode = "True";
3736
var write = function (str) {
3837
_this.output.innerHTML += _this.outputfun(str);
@@ -41,27 +40,16 @@ export default class JSActiveCode extends ActiveCode {
4140
if (!str) str = "";
4241
_this.output.innerHTML += _this.outputfun(str) + "<br />";
4342
};
44-
saveCode = await this.manage_scrubber(saveCode);
43+
this.saveCode = await this.manage_scrubber(saveCode);
4544
$(this.eContainer).remove();
4645
$(this.output).text("");
4746
$(this.outDiv).show({ duration: 700, queue: false });
4847
try {
4948
eval(prog);
50-
einfo = "success";
49+
this.errinfo = "success";
5150
} catch (e) {
5251
this.addErrorMessage(e);
53-
einfo = e;
52+
this.errinfo = e;
5453
}
55-
// Note that, since this isn't awaited, the request may not be complete when this function returns.
56-
this.logRunEvent({
57-
div_id: this.divid,
58-
code: this.editor.getValue(),
59-
errinfo: einfo,
60-
lang: this.language,
61-
to_save: saveCode,
62-
prefix: this.pretext,
63-
suffix: this.suffix,
64-
partner: this.partner,
65-
});
6654
}
6755
}

0 commit comments

Comments
 (0)