Skip to content

Commit f55f698

Browse files
committed
that was just such a terrible idea
1 parent 1aaeffe commit f55f698

File tree

4 files changed

+4
-35
lines changed

4 files changed

+4
-35
lines changed

Diff for: requirements/base.txt

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ django-taggit==0.15.0
2121
# Django-reversion 1.9.2 for Django 1.7+
2222
django-reversion==1.9.2
2323
Markdown==2.3.1
24-
django-selectable==0.9.0
2524

2625
django-forms-bootstrap==2.0.3.post1
2726
django-uni-form==0.9.0

Diff for: symposion/proposals/forms.py

+4-15
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,17 @@
22
from django.db.models import Q
33
from django.utils.translation import ugettext_lazy as _
44

5-
from selectable import forms as selectable
6-
75
from taggit.forms import TagField
86

97
from symposion.proposals.models import SupportingDocument
108

11-
from .lookups import UserLookup
12-
139
# @@@ generic proposal form
1410

1511

1612
class AddSpeakerForm(forms.Form):
1713

18-
email = selectable.AutoCompleteSelectField(
19-
lookup_class=UserLookup,
20-
allow_new=True,
21-
label=_("Email address"),
22-
required=True,
14+
email = forms.EmailField(
15+
label="Email address of new speaker (use their email address, not yours)"
2316
)
2417

2518
def __init__(self, *args, **kwargs):
@@ -28,10 +21,7 @@ def __init__(self, *args, **kwargs):
2821

2922
def clean_email(self):
3023
value = self.cleaned_data["email"]
31-
# django-selectable returns the user
32-
if isinstance(value, UserLookup.model):
33-
value = value.email
34-
if value == self.proposal.speaker.email:
24+
if value.lower() == self.proposal.speaker.email.lower():
3525
raise forms.ValidationError(
3626
_("You have submitted the Proposal author's email address. Please" \
3727
" select another email address.")
@@ -42,11 +32,10 @@ def clean_email(self):
4232
).exists()
4333
if exists:
4434
raise forms.ValidationError(
45-
_("This email address has already been invited to your talk proposal")
35+
"This email address has already been invited to your talk proposal"
4636
)
4737
return value
4838

49-
5039
class SupportingDocumentCreateForm(forms.ModelForm):
5140

5241
class Meta:

Diff for: symposion/templates/proposals/proposal_speaker_manage.html

-18
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,6 @@
44
{% load bootstrap_tags %}
55
{% load i18n %}
66

7-
{% block extra_style %}
8-
<link rel="stylesheet" type="text/css"
9-
href="//ajax.googleapis.com/ajax/libs/jqueryui/1.10.4/themes/smoothness/jquery-ui.css">
10-
<link type="text/css" media="all" rel="stylesheet"
11-
href="{{ STATIC_URL }}selectable/css/dj.selectable.css">
12-
{% endblock extra_style %}
13-
14-
{% comment %}
15-
Overwriting extra_head_base to remove markedit JS, which causes conflicts
16-
with selectable (JQuery UI)
17-
{% endcomment %}
18-
197
{% block head_title %}Manage Speakers{% endblock head_title %}
208

219
{% block body %}
@@ -53,9 +41,3 @@ <h2>{% trans "Add another speaker" %}</h2>
5341
});
5442
</script>
5543
{% endblock %}
56-
57-
58-
{% block extra_script %}
59-
<script src="//ajax.googleapis.com/ajax/libs/jqueryui/1.10.4/jquery-ui.js"></script>
60-
{{ add_speaker_form.media.js }}
61-
{% endblock extra_script %}

Diff for: symposion/urls.py

-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060

6161
url(r"^boxes/", include("symposion.boxes.urls")),
6262
url(r"^sitemap/", TemplateView.as_view(template_name="static/sitemap.html"), name="sitemap"),
63-
url(r'^selectable/', include('selectable.urls')),
6463
url(r"^change_language/", symposion.views.change_language, name="change_language"),
6564
url(r"^mentorship/", include("pycon.mentorship.urls")),
6665
url(r"^", include("pycon.urls")),

0 commit comments

Comments
 (0)