-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add #[pyclass(generic)]
#4926
base: main
Are you sure you want to change the base?
Add #[pyclass(generic)]
#4926
Conversation
Assuming we want to go with As for the error: what this builder does is that it a) emits an pyo3/pyo3-macros-backend/src/pyclass.rs Lines 456 to 462 in f2a8460
This should also prevent the user from both writing |
I added tests and updated the documentation. I am confident it all works. For compilation failure, I tested users redefining I am still not sure how to block |
Closes #4849
Follow up of #4917
generic
for enums; let's focus only on supporting structs for nowError in Python 3.7 and 3.8(it just fails to compile for now)edit: it is mostly ready to review now