Corrects TCT constraint #521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ktehranchi, as you did the original implementation of TCT, and I uncommented some of your code, could you do a quick review of this please? I just want to make sure I didnt change how you envisioned the TCT constraint. |
2 tasks
|
Added assertion that will flag if a max capacity limit is higher than existing installed capacity For example, this will print out: |
ktehranchi
reviewed
Feb 4, 2025
| n.model.add_constraints( | ||
| lhs >= (target["min"]), | ||
| name=f"GlobalConstraint-{target.name}_{target.planning_horizon}_min", |
There was a problem hiding this comment.
The reason I have "GlobalConstraint" appended is to be able to get pypsa to export the shadow price of the constraint (PyPSA/PyPSA#850) . So it'd be good to add that back!
|
LGTM but added one comment on the naming of the constraint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #520
Changes proposed in this Pull Request
In this PR I update the TCT constraint logic. Specifically, I have removed existing capacity from the rhs of the constraint equation, and left the summation over only extendable generators.
For example, if there is 10MW of existing solar capacity, and the target is at least 50MW, the constraint will read:
I think to improve interoperability between electricity and sector, it would be nice to not hard code in the
GeneratorandStorageUnitcomponent filtering, but I will add that as a new issue.Checklist
envs/environment.yaml.config.default.yaml.doc/configtables/*.csv.