From 19200e15a1dac7cebfb6e0cc9b6e45b989d7800f Mon Sep 17 00:00:00 2001 From: korgan00 Date: Mon, 31 Aug 2026 14:19:52 +0200 Subject: [PATCH 1/2] remove version on client --- .../qiskit_serverless/core/clients/serverless_client.py | 4 +--- client/tests/core/test_job.py | 8 ++++---- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/client/qiskit_serverless/core/clients/serverless_client.py b/client/qiskit_serverless/core/clients/serverless_client.py index e7f3025ea..afcd67470 100644 --- a/client/qiskit_serverless/core/clients/serverless_client.py +++ b/client/qiskit_serverless/core/clients/serverless_client.py @@ -107,7 +107,6 @@ class ServerlessClient(BaseClient): # pylint: disable=too-many-public-methods def __init__( # pylint: disable=too-many-positional-arguments self, host: Optional[str] = None, - version: Optional[str] = None, token: Optional[str] = None, instance: Optional[str] = None, channel: Optional[str] = None, @@ -117,7 +116,6 @@ def __init__( # pylint: disable=too-many-positional-arguments Args: host: host of gateway. If None, it uses the ENV_GATEWAY_PROVIDER_HOST env var - version: version of gateway token: authorization token instance: IBM Cloud CRN channel: identifies the method to use to authenticate the user @@ -127,7 +125,7 @@ def __init__( # pylint: disable=too-many-positional-arguments raise QiskitServerlessException("Please provide `host` of gateway.") host = host.rstrip("/") - version = version or os.environ.get(ENV_GATEWAY_PROVIDER_VERSION) + version = os.environ.get(ENV_GATEWAY_PROVIDER_VERSION) if version is None: version = GATEWAY_PROVIDER_VERSION_DEFAULT diff --git a/client/tests/core/test_job.py b/client/tests/core/test_job.py index b43bb3d12..fb84187d6 100644 --- a/client/tests/core/test_job.py +++ b/client/tests/core/test_job.py @@ -131,7 +131,7 @@ def test_update_sub_status(self, job_env_variables): @patch("requests.get", Mock(return_value=ResponseMock())) def test_filtered_logs(self): """Tests job filtered log.""" - client = ServerlessClient(host="host", token="token", instance="instance", version="version") + client = ServerlessClient(host="host", token="token", instance="instance") client.logs = MagicMock( return_value="This is the line 1\nThis is the second line\nOK. This is the last line.\n", # pylint: disable=line-too-long ) @@ -142,7 +142,7 @@ def test_filtered_logs(self): @patch("requests.get", Mock(return_value=ResponseMock())) def test_error_message(self): """Tests job filtered log.""" - client = ServerlessClient(host="host", token="token", instance="instance", version="version") + client = ServerlessClient(host="host", token="token", instance="instance") client.status = MagicMock( return_value="ERROR", ) @@ -167,7 +167,7 @@ def test_error_message(self): ) def test_runtime_sessions(self): """Tests runtime session id retrieval for serverless job.""" - client = ServerlessClient(host="host", token="token", instance="instance", version="v1") + client = ServerlessClient(host="host", token="token", instance="instance") job_id = "8317718f-5c0d-4fb6-9947-72e480b8a348" runtime_sessions = client.runtime_sessions(job_id) @@ -182,7 +182,7 @@ def test_runtime_sessions(self): ) def test_runtime_jobs(self): """Tests runtime job id retrieval for serverless job.""" - client = ServerlessClient(host="host", token="token", instance="instance", version="v1") + client = ServerlessClient(host="host", token="token", instance="instance") job_id = "8317718f-5c0d-4fb6-9947-72e480b8a348" runtime_jobs = client.runtime_jobs(job_id) From 2970ddbcbd3619cf920904d75a9f26fa3f387d92 Mon Sep 17 00:00:00 2001 From: korgan00 Date: Wed, 2 Sep 2026 17:45:55 +0200 Subject: [PATCH 2/2] fix version --- client/tests/core/test_serverless_client_functions.py | 1 - client/tests/core/test_serverless_client_jobs.py | 1 - 2 files changed, 2 deletions(-) diff --git a/client/tests/core/test_serverless_client_functions.py b/client/tests/core/test_serverless_client_functions.py index 47ef0a5ba..cec9fb923 100644 --- a/client/tests/core/test_serverless_client_functions.py +++ b/client/tests/core/test_serverless_client_functions.py @@ -42,7 +42,6 @@ def mock_client(): token="test-token", instance="test-instance", channel="ibm_quantum_platform", - version="v1", ) return client diff --git a/client/tests/core/test_serverless_client_jobs.py b/client/tests/core/test_serverless_client_jobs.py index f85256a0f..17ec422d8 100644 --- a/client/tests/core/test_serverless_client_jobs.py +++ b/client/tests/core/test_serverless_client_jobs.py @@ -35,7 +35,6 @@ def mock_client(): host="https://test-host.com", token="test-token", instance="test-instance", - version="v1", ) return client