Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Github action and co #3

Open
4 tasks
Carreau opened this issue May 3, 2024 · 3 comments
Open
4 tasks

Setup Github action and co #3

Carreau opened this issue May 3, 2024 · 3 comments

Comments

@Carreau
Copy link
Collaborator

Carreau commented May 3, 2024

  • Github action
  • Pre-commits
    • black/ruff
    • mypy
@agriyakhetarpal
Copy link
Member

agriyakhetarpal commented May 3, 2024

A link checker would be helpful to add – though it can only validate if a link exists, and not whether it serves as an inventory, it would still be good to check for 404s from time to time. Lychee is a strong and robust candidate and is quite fast as well.

(Let me know if you want me to do this)

@Carreau
Copy link
Collaborator Author

Carreau commented May 3, 2024

The test suite does a pytest head request to check that the obj.inv exists.
We could, and it would be great to check that the obj.inv are valid. I think the tool posted in #2 could help with that.

@agriyakhetarpal
Copy link
Member

Ah, in that case the test suite is better to use, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants