backout oracle updates

Author: dfrankland

dataframely/_compat.py

@@ -18,7 +18,6 @@ def __getattr__(self, name: str) -> Any:
 try:
     import sqlalchemy as sa
     import sqlalchemy.dialects.mssql as sa_mssql
-    import sqlalchemy.dialects.oracle as sa_oracle
     import sqlalchemy.dialects.postgresql as sa_postgresql
     from sqlalchemy.sql.type_api import TypeEngine as sa_TypeEngine
 except ImportError:  # pragma: no cover
@@ -38,4 +37,4 @@ class sa_TypeEngine:  # type: ignore # noqa: N801
 
 # ------------------------------------------------------------------------------------ #
 
-__all__ = ["sa", "sa_mssql", "sa_oracle", "sa_postgresql", "sa_TypeEngine", "pa"]
+__all__ = ["sa", "sa_mssql", "sa_postgresql", "sa_TypeEngine", "pa"]

dataframely/columns/datetime.py

@@ -14,7 +14,6 @@
     pa,
     sa,
     sa_mssql,
-    sa_oracle,
     sa_postgresql,
     sa_TypeEngine,
 )
@@ -349,8 +348,6 @@ def sqlalchemy_dtype(self, dialect: sa.Dialect) -> sa_TypeEngine:
                 return sa_mssql.DATETIME2(6, timezone=timezone_enabled)
             case "postgresql":
                 return sa_postgresql.TIMESTAMP(timezone=timezone_enabled)
-            case "oracle":
-                return sa_oracle.TIMESTAMP(timezone=timezone_enabled)
             case _:
                 return sa.DateTime(timezone=timezone_enabled)
 

tests/columns/test_sql_schema.py

@@ -4,7 +4,6 @@
 import pytest
 import sqlalchemy as sa
 from sqlalchemy.dialects.mssql.pyodbc import MSDialect_pyodbc
-from sqlalchemy.dialects.oracle.oracledb import OracleDialect_oracledb
 from sqlalchemy.dialects.postgresql.psycopg2 import PGDialect_psycopg2
 
 import dataframely as dy
@@ -103,51 +102,6 @@ def test_postgres_datatype(column: Column, datatype: str) -> None:
     assert columns[0].type.compile(dialect) == datatype
 
 
-@pytest.mark.parametrize(
-    ("column", "datatype"),
-    [
-        (dy.Bool(), "SMALLINT"),
-        (dy.Date(), "DATE"),
-        (dy.Datetime(), "TIMESTAMP"),
-        (dy.Datetime(time_zone="Etc/UTC"), "TIMESTAMP WITH TIME ZONE"),
-        (dy.Time(), "TIME"),
-        (dy.Duration(), "INTERVAL DAY TO SECOND"),
-        (dy.Decimal(), "NUMERIC"),
-        (dy.Decimal(12), "NUMERIC(12, 0)"),
-        (dy.Decimal(None, 8), "NUMERIC(38, 8)"),
-        (dy.Decimal(6, 2), "NUMERIC(6, 2)"),
-        (dy.Float(), "FLOAT"),
-        (dy.Float32(), "REAL"),
-        (dy.Float64(), "FLOAT"),
-        (dy.Integer(), "INTEGER"),
-        (dy.Int8(), "SMALLINT"),
-        (dy.Int16(), "SMALLINT"),
-        (dy.Int32(), "INTEGER"),
-        (dy.Int64(), "NUMBER(19)"),
-        (dy.UInt8(), "SMALLINT"),
-        (dy.UInt16(), "INTEGER"),
-        (dy.UInt32(), "NUMBER(19)"),
-        (dy.UInt64(), "NUMBER(19)"),
-        (dy.String(), "VARCHAR2"),
-        (dy.String(min_length=3), "VARCHAR2"),
-        (dy.String(max_length=5), "VARCHAR2(5 CHAR)"),
-        (dy.String(min_length=3, max_length=5), "VARCHAR2(5 CHAR)"),
-        (dy.String(min_length=5, max_length=5), "CHAR(5)"),
-        (dy.String(regex="[abc]de"), "VARCHAR2"),
-        (dy.String(regex="^[abc]d$"), "CHAR(2)"),
-        (dy.String(regex="^[abc]{1,3}d$"), "VARCHAR2(4 CHAR)"),
-        (dy.Enum(["foo", "bar"]), "CHAR(3)"),
-        (dy.Enum(["a", "abc"]), "VARCHAR2(3 CHAR)"),
-    ],
-)
-def test_oracle_datatype(column: Column, datatype: str) -> None:
-    dialect = OracleDialect_oracledb()
-    schema = create_schema("test", {"a": column})
-    columns = schema.sql_schema(dialect)
-    assert len(columns) == 1
-    assert columns[0].type.compile(dialect) == datatype
-
-
 @pytest.mark.parametrize("column_type", COLUMN_TYPES)
 @pytest.mark.parametrize("nullable", [True, False])
 @pytest.mark.parametrize("dialect", [MSDialect_pyodbc()])