feat: post-rebase 1Q squashing in QSystemPass#1430
Draft
Conversation
CalMacCQ
commented
Mar 10, 2026
| .unwrap(); | ||
|
|
||
| let (mut hugr, [call_node, h_node, f_node, rx_node, main_node]) = { | ||
| let (mut hugr, [call_node, h_node, f_node, rz_node, main_node]) = { |
Contributor
Author
There was a problem hiding this comment.
This was a typo I think
Contributor
Author
There was a problem hiding this comment.
This surely isn't the breaking change hugrbot is mentioning below.
EDIT: this is a test so it shouldn't be part of the API
CalMacCQ
commented
Mar 24, 2026
| } | ||
| // restore the entrypoint | ||
| hugr.set_entrypoint(entrypoint); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
TODO: Call the NormalizeGuppy pass before applying the squash pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still have plenty of work to do on this (including fixing some failing tests)
closes #1419
Also one the issues are fixed I need to do proper testing with other components in the stack before this can be merged.