-
Notifications
You must be signed in to change notification settings - Fork 5
Representations of alternating group of degree 4 #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great start!
In general it looks like most of the implementations really assume N = 4 and are not at all expected to work for anything else, this is completely fine, but the signatures should then be made more specific as well.
|
So, I read a bit more about the representation theory of the alternating groups, and there are a couple points that I want to revisit. The first is that if we want this to really be Therefore I would kind of like to suggest an alternative, where we simply define I'm happy to have a go at this tomorrow if you don't object to this. |
|
I have also been wondering about this and fully agree with Lukas' analysis, and the decision of simply restricting to |
|
Seems reasonable. Feel free to go for it! |
Co-authored-by: Lukas Devos <[email protected]>
|
I will add the intertwiner test tomorrow :) |
|
That's actually really cool that just works, thanks for implementing! |
lkdvos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, this PR looks great to me!
@Jutho, do you have any opinions about choosing the symmetric or antisymmetric channel first? Do we know if there are any conventions around this, or can we really just pick freely?
If so, I'd be happy to merge and tag this!
| Base.hash(a::A4Irrep, h::UInt) = hash(a.n, h) | ||
| Base.convert(::Type{A4Irrep}, n::Integer) = A4Irrep(n) | ||
|
|
||
| Base.getindex(::IrrepTable, ::Type{A₄}) = A4Irrep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that here you could in principle also register the lower order alternating group versions, something like
Base.getindex(::IrrepTable, ::Type{Alternating{3}}) = ZNIrrep{3}though that might be more confusing than helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though I started with including the lower degree groups, and whether or not it's confusing or helpful, I don't think that making these identifications is particularly useful.
I don't know if there is any convention. I am actually not really familiar with the representation theory of A4. So I don't have strong opinions. Is this something @lalooten knows more about? |
|
Had a quick chat with @lalooten, seems like there isn't really any convention to keep in mind, so I will merge and release this as it is now. Thanks again @borisdevos ! |
This PR adds the representations of A_N for 0 < N < 5. In particular, RepA4 has a generic fusion style, which is currently untested in TensorKit.This PR adds the representations of the alternating group of degree 4, providing a sector with generic fusion style.
Credits to @lkdvos for several parts of this PR.