-
-
Notifications
You must be signed in to change notification settings - Fork 14
Initialize asyncio event loop before using it #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PipelineRetryFailed |
ce945b7 to
9eeaeb9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 90.20% 89.65% -0.56%
==========================================
Files 3 3
Lines 143 145 +2
==========================================
+ Hits 129 130 +1
- Misses 14 15 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025091702-4.3-fedora&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests27 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 82 fixed
Unstable testsPerformance TestsPerformance degradation:4 performance degradations
Remaining performance tests:78 tests
|
|
This doesn't work: |
9eeaeb9 to
d86e259
Compare
Fix applied |
marmarek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and also, split CI update into separate commit please
qubesidle/idle_watcher_window.py
Outdated
| self.wait_future = None | ||
|
|
||
| file_descriptor = self.conn.get_file_descriptor() | ||
| asyncio.set_event_loop(asyncio.new_event_loop()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
creating new loop from within a plugin is a bad idea, better to do that before in main before loading them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also done. Two places. In main function and in unittest setup
Python 3.14 (in Fedora 43) throws RunetimeError if event loop is not initialized before using it. Resolves: QubesOS/qubes-issues#10188
d86e259 to
2b8220c
Compare
This is done |
Python 3.14 (in Fedora 43) throws RunetimeError if event loop is not initialized before using it.
Resolves: QubesOS/qubes-issues#10188