-
-
Notifications
You must be signed in to change notification settings - Fork 127
qubes-fs-tree-check: Use relative source path for validation #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
qubes_pure_validate_symbolic_link_v2() checks that the symlink is not to be written to an absolute path. qfile-unpacker correctly passes a relattive path to this function, but qubes-fs-tree-check wrongly passed an absolute path. As a result, operations like 'qvm-copy ~/something' where ~/something contains symlinks are wrongly rejected. Fixes QubesOS/qubes-issues#10284
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
=======================================
Coverage 71.10% 71.10%
=======================================
Files 3 3
Lines 481 481
=======================================
Hits 342 342
Misses 139 139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025101005-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests17 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 83 fixed
Unstable testsPerformance TestsPerformance degradation:13 performance degradations
Remaining performance tests:166 tests
|
qubes_pure_validate_symbolic_link_v2() checks that the symlink is not to be written to an absolute path. qfile-unpacker correctly passes a relattive path to this function, but qubes-fs-tree-check wrongly passed an absolute path. As a result, operations like 'qvm-copy ~/something' where ~/something contains symlinks are wrongly rejected.
Fixes QubesOS/qubes-issues#10284