Skip to content

qrexec-policy-agent: Replace usage of deprecated Gtk.Entry.set_icon_from_stock #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

qrexec-policy-agent: Replace usage of deprecated Gtk.Entry.set_icon_from_stock #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions qrexec/tools/qrexec_policy_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,23 @@ def __init__(self, domains_info=None):
self._domains_info = domains_info
self._icons = {}
self._icon_size = 16
self._find_icon = None
self._theme = Gtk.IconTheme.get_default()
self._create_entries()

def _get_find_icon(self):
if self._find_icon is None:
self._find_icon = self._theme.load_icon(
"edit-find", self._icon_size, 0
)
return self._find_icon

def _get_icon(self, name):
if name not in self._icons:
try:
icon = self._theme.load_icon(name, self._icon_size, 0)
except GLib.Error: # pylint: disable=catching-non-exception
icon = self._theme.load_icon("edit-find", self._icon_size, 0)
icon = self._get_find_icon()

self._icons[name] = icon

Expand Down Expand Up @@ -128,8 +136,8 @@ def _combo_change(self, selection_trigger, combo, entry_box, whitelist):
)
else:
if entry_box:
entry_box.set_icon_from_stock(
Gtk.EntryIconPosition.PRIMARY, "gtk-find"
entry_box.set_icon_from_pixbuf(
Gtk.EntryIconPosition.PRIMARY, self._get_find_icon()
)

if selection_trigger:
Expand Down